JmsListener/ScheduledAnnotationBeanPostProcessor should use SmartInitializingSingleton instead of ContextRefreshedEvent [SPR-12039]

[spring-projects-issues]

Juergen Hoeller opened SPR-12039 and commented

Both JmsListenerAnnotationBeanPostProcessor and ScheduledAnnotationBeanPostProcessor traditionally implement ApplicationListener<ContextRefreshedEvent> to perform their registration tasks as late as possible. The new SmartInitializingSingleton mechanism in Spring 4.1 is a better fit since it kicks in right after the singleton pre-instantiation phase but before the phased lifecycle startup phase.

In the case of JmsListenerAnnotationBeanPostProcessor, this is particularly important since JmsListenerEndpointRegistry otherwise misses to propagate its phased start signal to the listener containers that it manages. This currently shows in the form that an explicit context.start() call is needed for annotated JMS endpoints.

---

Affects: 4.1 RC1

Issue Links:

• ScheduledAnnotationBeanPostProcessor registers schedules twice in web application [SPR-6656] #11322 ScheduledAnnotationBeanPostProcessor registers schedules twice in web application
• Annotation-driven JMS endpoints [SPR-9882] #14515 Annotation-driven JMS endpoints
• During startup scheduled tasks are driven earlier than before causing problems with Spring Batch [SPR-12641] #17242 During startup scheduled tasks are driven earlier than before causing problems with Spring Batch

Referenced from: commits 92c657e