MockHttpServletResponse.setDateHeader does not perform date formatting [SPR-11912]

[spring-projects-issues]

Samuel Halliday opened SPR-11912 and commented

Status Quo

HttpServletResponse.setDateHeader takes a long parameter and is supposed to set the HTTP header as a string in RFC 2616 format.

However, the setDateHeader and addDateHeader methods in MockHttpServletResponse simply save the supplied long value as-is. For example, MockHttpServletResponse.getHeader("Last-Modified") will return 0L and not the RFC formatted string.

This makes it impossible to use this mock to test behavior in date header fields.

Proposals

1. One possible fix would be to provide a getDateHeader accessor.
2. Another option would be to immediately convert date headers to formatted strings when they are added or set and store the formatted strings instead of longs.

The same goes for the request side: please provide a setDateHeader method in MockHttpServletRequest.

---

Affects: 3.1.4

Issue Links:

• MockHttpServletRequest does not handle rfc formatted dates. [SPR-12056] #16672 MockHttpServletRequest does not handle rfc formatted dates. ("is duplicated by")
• MockHttpServletRequest and MockHttpServletResponse should re-use date patterns / parsers / formatters from HttpHeaders [SPR-16312] #20859 MockHttpServletRequest and MockHttpServletResponse should re-use date patterns / parsers / formatters from HttpHeaders
• Add a new ResultMatcher for date formats in HTTP headers [SPR-13263] #17854 Add a new ResultMatcher for date formats in HTTP headers

Referenced from: commits 43e36e2

0 votes, 7 watchers

[spring-projects-issues]

Eujung Kim commented

I agreed to reporter's opinion, so I improved MockHttpServletRequest.java and MockHttpServletResponse.java.

And I submitted pull request.
#591

Thanks.

[spring-projects-issues]

Sam Brannen commented

See also: #614

[spring-projects-issues]

Sam Brannen commented

Brian Clozel, since you just pushed related code changes to MockHttpServletResponse in spring-web in GitHub commit 088a50c, I am assigning this to you for 4.2 GA.

Please perform the same changes to the official MockHttpServletResponse in spring-test and attribute yourself as an @author in both places. In addition, please introduce corresponding tests in MockHttpServletResponseTests.

Thanks!

Sam

p.s. Please consult the two pull requests linked from this issue as well and close them as appropriate.

[spring-projects-issues]

Brian Clozel commented

A PR is ready for discussion here.