Allow configuration of path mapping options for websocket handler mapping (e.g. alwaysUseFullPath) [SPR-11771]

[spring-projects-issues]

zyro opened SPR-11771 and commented

when we got a scenario like this:

• DispatcherServlet servlet-mapping like \*.do and /stomp/\*
• stomp endpoint registration on /stomp

the requests will not match because AbstractHandlerMapping.alwaysUseFullPath is false by default and so e.g. a request to /stomp/info will lead to a lookup-path of /info which does not match the sockJS handler-mapping, that gets a pattern of /stomp/**

dirty workaround for me was applicationContext.getBean("stompWebSocketHandlerMapping").setAlwaysUseFullPath(true) when the context is fully loaded.

would be cool to get a chance to configure the handlerMapping itself, or at least the alwaysUseFullPath flag using AbstractWebSocketMessageBrokerConfigurer, without needing to fall back to WebSocketMessageBrokerConfigurationSupport overrding the whole handlerMapping bean.

maybe relevant for webSocketHandlerMapping as well?

---

Affects: 4.0.4

Issue Links:

• Configuration of path mapping options for websockets via XML [SPR-12621] #17222 Configuration of path mapping options for websockets via XML

1 votes, 3 watchers

[spring-projects-issues]

Rossen Stoyanchev commented

Okay we'll look into making this more configurable.

To make sure I understand the case, you have two DispatcherServlet's one mapped to "\*.do" and another to "/stomp/\*", is that right?

[spring-projects-issues]

zyro commented

i am talking about a servlet-mapping like this:

  <servlet>
    <servlet-name>dispatcherServlet</servlet-name>
    <servlet-class>org.springframework.web.servlet.DispatcherServlet</servlet-class>
    <async-supported>true</async-supported>
  </servlet>

  <servlet-mapping>
    <servlet-name>dispatcherServlet</servlet-name>
    <url-pattern>/stomp/*</url-pattern>
  </servlet-mapping>
  <servlet-mapping>
    <servlet-name>dispatcherServlet</servlet-name>
    <url-pattern>*.do</url-pattern>
  </servlet-mapping>

thanks, zyro

[spring-projects-issues]

Rossen Stoyanchev commented

Okay thanks.

[spring-projects-issues]

Rossen Stoyanchev commented

I've added an option for this. By default WebSocketMessageBrokerConfigurer gives you a StompEndpointRegistry. Downcast it to WebMvcStompEndpointRegistry and you can then set the UrlPathHelper property.