Regression: AbstractHttpMessageConverter does not set ContentType [SPR-11685]

[spring-projects-issues]

Thierry Messer opened SPR-11685 and commented

AbstractHttpMessageConverter does no longer set the content type of the generated message. It's now always text/html.
This is due to the fact that in a servlet3 environment the class ServletServerHttpResponse uses the new inner class ServletResponseHttpHeaders rather than HttpHeaders.
ServletServerHttpResponse returns the header values of the wrapped HttpServletResponse unlike HttpHeaders which returns null.
This causes the AbstractHttpMessageConverter to not set the ContentType header.

---

Affects: 4.0.3

Issue Links:

• Truncated HTTP responses [SPR-8867] #13509 Truncated HTTP responses
• CORS for websocket breaks existing CORS Filter [SPR-11443] #16069 CORS for websocket breaks existing CORS Filter
• Improve Servlet 3 presence check in ServletServerHttpResponse [SPR-11712] #16334 Improve Servlet 3 presence check in ServletServerHttpResponse

1 votes, 4 watchers

[spring-projects-issues]

Rossen Stoyanchev commented

It's now always text/html.

Something must be setting the contentType of the HttpServletResponse to "text/html". Any idea what's doing that?

The issue is not easily reproducible. The MessageConvertersController in the spring-mvc-showcase works as expected. Note however that I fixed one issue in the sample with code that was erroneously committed earlier. See this commit.

I think it's important to understand what's setting the content type to "text/html". After all ServletServerHttpResponse is doing what it was designed to do, i.e. update the contentType property of the response only if not already set.

[spring-projects-issues]

Rossen Stoyanchev commented

Thierry Messer, do you have any comments?