Duplicate key violation gets translated to DataIntegrityViolationException instead of DuplicateKeyException when using JPA (Hibernate) [SPR-11669]

[spring-projects-issues]

Kazuki Shimizu opened SPR-11669 and commented

Environment

• JAP( Hibernate 4.2.3.Final )
• Spring Data JPA 1.4.3.RELEASE
• H2 Database 1.3.172 (In memory mode)
• Java 1.7.0_51
• Tomcat 7.0.47

DataIntegrityViolationException is occurred when violate a primary key or unique key constraint.
This behavior is specification ?
I think that should be thrown DuplicateKeyException.

When using JDBC(Mybatis3), occurred a DuplicateKeyException.

How do think?

---

Affects: 3.2.8

Issue Links:

• Lock error is not translated to PessimisticLockingFailureException or subclass when using JPA (Hibernate) [SPR-11670] #16293 Lock error is not translated to PessimisticLockingFailureException or subclass when using JPA (Hibernate)

Referenced from: commits spring-attic/spring-framework-issues@9a6d454, spring-attic/spring-framework-issues@d50e4b8

2 votes, 9 watchers

[spring-projects-issues]

Stéphane Nicoll commented

do you have a simple use case that reproduces this issue? Better, can you create a sample project? Thanks!

[spring-projects-issues]

Kazuki Shimizu commented

yes! I push the simple project of this issue later !

[spring-projects-issues]

Kazuki Shimizu commented

I send a pull-request of sample project.
spring-attic/spring-framework-issues#72

How to reproduce

1. view home screen (http://localhost:8080/SPR-11699/)
2. click to "Member Creation" link.
3. member creation is perform.
4. member creation is perform again. (email specify same value of before operation)
5. violation error of unique key constraint occurred.

Please confirm sample project.

[spring-projects-issues]

Stéphane Nicoll commented

Thanks for the project. I have merged it and modified it to a Jar project with a unit test. That way, running the unit test demonstrates the same behaviour
https://github.com/spring-projects/spring-framework-issues/tree/master/SPR-11669

[spring-projects-issues]

Kazuki Shimizu commented

Thank you for merge & migrate to jar project.
I tried the upgrade to 4.0.3.RELEASE, but result was same.

[spring-projects-issues]

Stéphane Nicoll commented

indeed. Sorry I didn't report that here.

[spring-projects-issues]

Juergen Hoeller commented

What's the underlying native Hibernate exception there? A ConstraintViolationException, I suppose?

We're only really translating a Hibernate NonUniqueObjectException to our DuplicateKeyException; everything else ends up as a DataIntegrityViolationException... That's consistently the case for our orm.hibernate3, orm.hibernate4 and also for our JPA HibernateJpaDialect though, so not really a bug. We may revisit this, of course, across all three of those places.

Juergen

[spring-projects-issues]

Kazuki Shimizu commented

Juergen , thanks with comment.

When key duplicated, I hope that be translated to DuplicateKeyException as with JDBC operation(JdbcTemplate or Mybatis etc..).

And..
NonUniqueObjectException of hibernate is occur when detected duplicate key in the same session. Therefore maybe can not detect duplicate key with other session. (look at the JavaDoc of NonUniqueObjectException)

I think that exception handing by spring-orm might be missing.
How do think?

[spring-projects-issues]

Stéphane Nicoll commented

Jürgen the SPR-11669 project gives the exact stacktrace:

org.springframework.dao.DataIntegrityViolationException: could not perform addBatch; SQL [/* insert org.springframework.issues.spr11669.domain.model.Member */ insert into member (email, name, id) values (?, ?, ?)]; constraint ["UK_MEMBER1_INDEX_8 ON PUBLIC.MEMBER(EMAIL)"; SQL statement:
/* insert org.springframework.issues.spr11669.domain.model.Member */ insert into member (email, name, id) values (?, ?, ?) [23505-172]]; nested exception is org.hibernate.exception.ConstraintViolationException: could not perform addBatch
	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:643)
	at org.springframework.orm.jpa.vendor.HibernateJpaDialect.translateExceptionIfPossible(HibernateJpaDialect.java:106)
	at org.springframework.orm.jpa.JpaTransactionManager.doCommit(JpaTransactionManager.java:517)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:755)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:724)
	at org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:475)
	at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:270)
	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:94)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
	at com.sun.proxy.$Proxy36.create(Unknown Source)
	at org.springframework.issues.spr11669.ReproTests.duplicateKey(ReproTests.java:58)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
	at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:83)
	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:168)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:72)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:231)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:88)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
	at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
	at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:71)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:174)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:77)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:195)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:63)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
Caused by: org.hibernate.exception.ConstraintViolationException: could not perform addBatch
	at org.hibernate.exception.internal.SQLStateConversionDelegate.convert(SQLStateConversionDelegate.java:129)
	at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:49)
	at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:125)
	at org.hibernate.engine.jdbc.batch.internal.BatchingBatch.performExecution(BatchingBatch.java:114)
	at org.hibernate.engine.jdbc.batch.internal.BatchingBatch.doExecuteBatch(BatchingBatch.java:101)
	at org.hibernate.engine.jdbc.batch.internal.AbstractBatchImpl.execute(AbstractBatchImpl.java:149)
	at org.hibernate.engine.jdbc.internal.JdbcCoordinatorImpl.executeBatch(JdbcCoordinatorImpl.java:198)
	at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:372)
	at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:286)
	at org.hibernate.event.internal.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:339)
	at org.hibernate.event.internal.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:52)
	at org.hibernate.internal.SessionImpl.flush(SessionImpl.java:1234)
	at org.hibernate.internal.SessionImpl.managedFlush(SessionImpl.java:404)
	at org.hibernate.engine.transaction.internal.jdbc.JdbcTransaction.beforeTransactionCommit(JdbcTransaction.java:101)
	at org.hibernate.engine.transaction.spi.AbstractTransactionImpl.commit(AbstractTransactionImpl.java:175)
	at org.hibernate.ejb.TransactionImpl.commit(TransactionImpl.java:75)
	at org.springframework.orm.jpa.JpaTransactionManager.doCommit(JpaTransactionManager.java:513)
	... 42 more
Caused by: org.h2.jdbc.JdbcBatchUpdateException: Unique index or primary key violation: "UK_MEMBER1_INDEX_8 ON PUBLIC.MEMBER(EMAIL)"; SQL statement:
/* insert org.springframework.issues.spr11669.domain.model.Member */ insert into member (email, name, id) values (?, ?, ?) [23505-172]
	at org.h2.jdbc.JdbcPreparedStatement.executeBatch(JdbcPreparedStatement.java:1167)
	at org.apache.commons.dbcp.DelegatingStatement.executeBatch(DelegatingStatement.java:297)
	at org.apache.commons.dbcp.DelegatingStatement.executeBatch(DelegatingStatement.java:297)
	at org.hibernate.engine.jdbc.batch.internal.BatchingBatch.performExecution(BatchingBatch.java:110)
	... 55 more

[spring-projects-issues]

Juergen Hoeller commented

So according to the stacktrace, Hibernate itself throws this as a plain ConstraintViolationException - apparently coming out of its batch statement handling, where H2 reports a JdbcBatchUpdateException instead of a more specific exception at the JDBC level. This is arguably something Hibernate should fix. On the Spring side, we'd have to dive two cause levels deep to even find an exception that contains a hint at that unique key problem... and that's an unusual thing to do, since we generally rely on Hibernate's exception capabilities.

Juergen

[spring-projects-issues]

Ankur Pathak commented

This isssue is still not fixed. And we get different behaviour for unique or primary key violation because of this in JPA and JDBC:

1. JDBC throws DuplicatekeyException
2. JPA throws DataIntegrityViolationException

Till it is fixed I have written a extension to Spring ORM JPA which deals with this issue by translating SQL Exception thrown.

Please check the details here for same: 

https://github.com/ankurpathak/spring-orm-jpa-extension

Its availabe on maven centrl