Unstable MVC test for controllers that returns DeferredResult [SPR-11536]

[spring-projects-issues]

Maxim Valyanskiy opened SPR-11536 and commented

Sometimes our tests fails with following exceptions:

java.lang.IllegalStateException: Gave up waiting on async result from handler [public org.springframework.web.context.request.async.DeferredResult<java.lang.String> SimpleController.handle()] to complete
	at org.springframework.test.web.servlet.DefaultMvcResult.getAsyncResult(DefaultMvcResult.java:133)
	at org.springframework.test.web.servlet.DefaultMvcResult.getAsyncResult(DefaultMvcResult.java:121)
	at org.springframework.test.web.servlet.result.RequestResultMatchers$3.match(RequestResultMatchers.java:94)
	at org.springframework.test.web.servlet.MockMvc$1.andExpect(MockMvc.java:149)
	at SimpleControllerTest.testSimple(SimpleControllerTest.java:35)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)

I reproduced this problem in sample application. Complete application is available at https://github.com/maxcom/spring-test-bug.

---

Affects: 4.0.2

Issue Links:

• Spring MVC Test can fail to obtain async result due to timing issue [SPR-11516] #16141 Spring MVC Test can fail to obtain async result due to timing issue ("duplicates")

1 votes, 3 watchers

[spring-projects-issues]

Ivan Sopov commented

I tried the test - and it fails only if the work "executes too fast" - less than 3 ms on my machine. If I change the random line to sleep(3) - everything is passing normally, if I change it to sleep(2) - the very first test fails. Also I I remove executor and return just the DeferredResult without any threading - problem is reproduced.

[spring-projects-issues]

Rossen Stoyanchev commented

Hi, thanks for providing the test project. This report coincides with recent comprehensive changes in this area based on #16141. I just switched the Spring Framework version in your test project to 4.0.3.BUILD-SNAPSHOT and it went through all 1000 iterations without errors. So I'll mark this as duplicate of #16141 for now and resolve it. It can be re-opened again if necessary but it should be addressed..