Optimize lookup of field errors in AbstractBindingResult [SPR-11304]

[spring-projects-issues]

Daniel Mikusa opened SPR-11304 and commented

There is a performance issue when Spring MVC validates a large object graph using JSR 303 Bean Validation API & Hibernated Validator.

Here is the object structure for the sample project in spring-framework-issues...

- Address
  - propA (string)
  - propB (string)
  - propC (List) // has around 100 elements
       - Object1
           - propA (string)
           - propB (List)  // has around 30 elements
               - Object 2
                    - propA
                    - propB
                    - propC

Worst case it takes about 2.5 seconds to process a request that fails validation. Without validation, processing is very fast.

---

Affects: 3.2.6, 4.0 GA

Issue Links:

• StringIndexOutOfBoundsException in AbstractErrors for class-level JSR-303 validator [SPR-11374] #16001 StringIndexOutOfBoundsException in AbstractErrors for class-level JSR-303 validator

Backported to: 3.2.7

[spring-projects-issues]

Rossen Stoyanchev commented

I've made a small optimization in AbstractErrors that improves performance by ~ 30%. The overall request time is still not ideal but the number of errors (~12K) is unusually large. Given some additional details on the specific scenario that leads to this, we could make further optimzations.