XStreamMarshaller doesn't set the converterRegistry field with XStream 1.4.5 [SPR-11147]

[spring-projects-issues]

Tomas Repel opened SPR-11147 and commented

When using XStreamMarshaller, I get following error

XStream marshalling ended with exception org.springframework.oxm.MarshallingFailureException: XStream marshalling exception;
nested exception is com.thoughtworks.xstream.converters.ConversionException: No converter specified for class springtest.xmlmarshalling.Data

After some debugging, I think the problem is that XStreamMarshaller's converterRegistry field is not initialized (it remains NULL, unlike the converterLookup field just a line above) and when the XStream object is being created in constructXStream() method, the NULL value causes that no converter is registered.

Let me know if you need more details or example war to reproduce this.

---

Affects: 4.0 RC2

Referenced from: commits 26d1438

[spring-projects-issues]

Phil Webb commented

Is this a problem that you are also seeing in 3.2.x or is it a 4.0 regression?

If you could submit a repro project for this, that would be very useful.

[spring-projects-issues]

Tomas Repel commented

I believe this is regression for Spring 4.0. PR for reproducer: spring-attic/spring-framework-issues#63

[spring-projects-issues]

Juergen Hoeller commented

This seems to be an XStream 1.4.5 specific problem. Before, XStream checked the given ConverterLookup object whether it also implements ConverterRegistry...

this.converterRegistry = converterRegistry != null
? converterRegistry
: (converterLookup instanceof ConverterRegistry
? (ConverterRegistry)converterLookup
: null);

But as of 1.4.5, it just assigns the converterRegistry reference as provided. We'll fix this for Spring 4.0 GA, hopefully compatible with XStream 1.4.x and also 1.4.5 then.