Cannot configure validationMessageSource when using Hibernate 5 as validation implementation [SPR-10466]

[spring-projects-issues]

David J. M. Karlsen opened SPR-10466 and commented

I configure the validation factory like this:

<bean id="validatorFactory"
     class="org.springframework.validation.beanvalidation.LocalValidatorFactoryBean">
     <property name="validationMessageSource">
          <ref bean="messageSource" />
     </property>
</bean>

and this throws this exception:

 Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'validatorFactory' defined in class path resource [META-INF/spring/validation-context.xml]: Error setting property values; nested exception is org.springframework.beans.PropertyBatchUpdateException; nested PropertyAccessExceptions (1) are:
PropertyAccessException 1: org.springframework.beans.MethodInvocationException: Property 'validationMessageSource' threw exception; nested exception is java.lang.NoClassDefFoundError: org/hibernate/validator/resourceloading/ResourceBundleLocator

it works just fine with Hibernate Validator v4.x but fails with the latest 5.0.0.Final

---

Affects: 3.2.2

Issue Links:

• Support Bean Validation 1.1 (JSR-349) [SPR-8199] #12848 Support Bean Validation 1.1 (JSR-349)

1 votes, 4 watchers

[spring-projects-issues]

Franz Neumann commented

The same things in my project

[spring-projects-issues]

Juergen Hoeller commented

This is due to Hibernate Validator 5.0 breaking its SPIs in a non-backwards-compatible way. Since this only affects HV 5.0 - the Bean Validation 1.1 reference implementation from the EE 7 umbrella -, we only plan to address this in the Spring Framework 4.0 line, where it has been fixed for the upcoming 4.0 M1 already.

Note that Spring Framework 4.0 keeps supporting Bean Validation 1.0 and hence the Hibernate Validator 4 generation, but requires HV 4.3 or higher now.

For Spring Framework 3.2.x, I'd recommend staying on Hibernate Validator 4.x or using native Bean Validation message lookup mechanisms only. Spring 3.2.x should work fine with Hibernate Validator 5.0 as long as no such vendor-specific mechanisms are being used.

Juergen

[spring-projects-issues]

Martin Frey commented

It is in fact quite easy to create a workaround for this until spring 4.0 is stable.

package ch.mfrey.beanvalidation;
 
import javax.validation.MessageInterpolator;

import org.hibernate.validator.messageinterpolation.ResourceBundleMessageInterpolator;
import org.springframework.context.MessageSource;

public class LocalValidatorFactoryBean extends org.springframework.validation.beanvalidation.LocalValidatorFactoryBean {
	
	private static class HibernateValidatorDelegate {

		public static MessageInterpolator buildMessageInterpolator(MessageSource messageSource) {
			return new ResourceBundleMessageInterpolator(new MessageSourceResourceBundleLocator(messageSource));
		}
	}

	@Override
	public void setValidationMessageSource(MessageSource messageSource) {
		setMessageInterpolator(HibernateValidatorDelegate.buildMessageInterpolator(messageSource));
	}

}

package ch.mfrey.beanvalidation;

import java.util.Locale;
import java.util.ResourceBundle;

import org.hibernate.validator.spi.resourceloading.ResourceBundleLocator;
import org.springframework.context.MessageSource;
import org.springframework.context.support.MessageSourceResourceBundle;
import org.springframework.util.Assert;

public class MessageSourceResourceBundleLocator implements ResourceBundleLocator {

	private final MessageSource messageSource;

	public MessageSourceResourceBundleLocator(MessageSource messageSource) {
		Assert.notNull(messageSource, "MessageSource must not be null");
		this.messageSource = messageSource;
	}

	@Override
	public ResourceBundle getResourceBundle(Locale locale) {
		return new MessageSourceResourceBundle(this.messageSource, locale);
	}

}

	<beans:bean id="validator"
		class="ch.mfrey.beanvalidation.LocalValidatorFactoryBean">
		<beans:property name="validationMessageSource" ref="messageSource" />
	</beans:bean>

	<mvc:annotation-driven validator="validator" />