HierarchicalUriComponents.equals() incorrectly returns false when other object is not an instance of OpaqueUriComponents [SPR-10088]

[spring-projects-issues]

Vasily Ivanov opened SPR-10088 and commented

org.springframework.web.util.HierarchicalUriComponents.equals(Object) method incorrectly returns false when other object is not an instance of OpaqueUriComponents:

final class HierarchicalUriComponents extends UriComponents {

public boolean equals(Object obj) {
...
   if (!(obj instanceof OpaqueUriComponents)) {
      return false;
   }
...
}

I believe it meant to be:

final class HierarchicalUriComponents extends UriComponents {

public boolean equals(Object obj) {
...
   if (!(obj instanceof HierarchicalUriComponents)) {
      return false;
   }
...
}

---

Affects: 3.1.3

Referenced from: commits b0fce78, 7af92b4

Backported to: 3.1.4

[spring-projects-issues]

Juergen Hoeller commented

Fixed for 3.2 GA and backported to 3.1.4 as well.

Juergen