ResourcePropertySource cannot load JDK 5 properties xml [SPR-9896]

[spring-projects-issues]

KwonNam Son opened SPR-9896 and commented

ResourcePropertySource cannot load JDK 5 properties XML.

I think that ResourcePropertySource#loadPropertiesForResource method's props.load(is) line has to be like the following:

String filename = resource.getFilename();
if (filename != null && filename.toLowerCase().endsWith(".xml")) {
	props.loadFromXML(is);
} else {
	props.load(is);
}

—

or just use PropertiesLoaderSupport class for loading properties.

---

Affects: 3.1.2

Referenced from: commits d5cad15, 3a626f9, a420e84

Backported to: 3.1.4

[spring-projects-issues]

Chris Beams commented

Thanks, KwonNam. This is resolved.

commit 3a626f93197d7f0fd4266d9877550a8d330017e5
Author: Chris Beams <cbeams@vmware.com>
Commit: Chris Beams <cbeams@vmware.com>

    Support XML properties in ResourcePropertySource
    
    JDK 5 introduced an XML-based properties file syntax. This commit
    ensures that when such files are supplied as the underlying resource
    for a ResourcePropertySource instance, they are routed appropriately
    to Properties#loadFromXML as opposed to Properties#load.
    
    Issue: SPR-9896