java.sql.SQLTimeoutException not translated to org.springframework.dao.QueryTimeoutException [SPR-9376]

[spring-projects-issues]

Sammy T Stag opened SPR-9376 and commented

java.sql.SQLTimeoutException is not translated to org.springframework.dao.QueryTimeoutException. I think line 74 of https://github.com/SpringSource/spring-framework/blob/master/spring-jdbc/src/main/java/org/springframework/jdbc/support/SQLExceptionSubclassTranslator.java should be updated to fix this.

I have searched the 3.1.1 codebase and can find no reference to QueryTimeoutException anywhere except in that class itself.

The issue can be reproduced as follows if using an Oracle database

JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource);
jdbcTemplate.setQueryTimeout(1);
String sql = "call dbms_lock.sleep(10)";
jdbcTemplate.execute(sql);

The attached unit test reproduces the issue. I used the oracle ojdbc6 driver version 11.2.0.3 (http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-112010-090769.html) and jdk7

---

Affects: 3.1.1

Attachments:

• test-data-source-context.xml (1.01 kB)
• TimeoutTest.java (1.19 kB)

Issue Links:

• Add QueryTimeoutException to the DataAccessException hierarchy [SPR-7680] #12336 Add QueryTimeoutException to the DataAccessException hierarchy
• SQLExceptionTranslators do not reliably translate QueryTimeoutException [SPR-11959] #16575 SQLExceptionTranslators do not reliably translate QueryTimeoutException

[spring-projects-issues]

Chris Beams commented

Thanks, Sammy.

commit 2db4e15f0e5fa6a4bdf3bb46d0d280ea16fc8dea
Author: Chris Beams <cbeams@vmware.com>
Date:   Tue May 15 14:50:31 2012 +0300

    Translate SQLTimeoutException to QueryTimeoutException
    
    SPR-7680 added QueryTimeoutException to Spring's DataAccessException
    hierarchy, but did not integrate it into the
    SQLExceptionSubclassTranslator; it was added mainly to accomodate users
    defining their own custom exception translators.
    
    However, it does make sense to translate any SQLTimeoutException to this
    new QueryTimeoutException type, and this commit makes that change. It
    does represent a slight backward-incompatibility, given that
    QueryTimeoutException extends TransientDataAccessException, whereas
    SQLExceptionSubclassTranslator previously returned the more specific
    TransientDataAccessResourceException for any SQLTimeoutException.
    
    It is expected that this incompatibily will be very low-impact, i.e. not
    affecting many (if any) users. In any case, a major release (Spring 3.2)
    is the right time to introduce such a change, and the migration path is
    straightforward: any users depending on catching
    TransientDataAccessResourceException in the case of query timeouts
    should update those catch blocks to expect QueryTimeoutException
    instead. Care should also be taken to ensure correctness of existing
    catch blocks expecting TransientDataAccessException, as these blocks
    will now catch QueryTimeoutException as well.
    
    Issue: SPR-9376, SPR-7680

[spring-projects-issues]

Sammy T Stag commented

Wow that was quick! Thanks