HibernateInterceptor variant for Hibernate 4 [SPR-9028]

[spring-projects-issues]

Per Edlund opened SPR-9028 and commented

When using the HibernateInterceptor with Hibernate4, org.springframework.orm.hibernate4.HibernateTransactionManager and org.springframework.orm.hibernate4.LocalSessionFactoryBean I'm getting a signature error which I don't really understand. I added a comment to one of the other issues regarding this, here's the stack trace

Caused by: java.lang.NoSuchMethodError: org.hibernate.SessionFactory.openSession()Lorg/hibernate/classic/Session;
at org.springframework.orm.hibernate3.SessionFactoryUtils.doGetSession(SessionFactoryUtils.java:322)
at org.springframework.orm.hibernate3.SessionFactoryUtils.getSession(SessionFactoryUtils.java:233)
at org.springframework.orm.hibernate3.HibernateInterceptor.getSession(HibernateInterceptor.java:145)
at org.springframework.orm.hibernate3.HibernateInterceptor.invoke(HibernateInterceptor.java:90)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
at $Proxy44.getAll(Unknown Source)

---

Affects: 3.1 GA

Attachments:

• HibernateInterceptor.java (12.12 kB)

Issue Links:

• Re-consider including HibernateTemplate and related classes for Hibernate 4 [SPR-11291] #15915 Re-consider including HibernateTemplate and related classes for Hibernate 4

10 votes, 18 watchers

[spring-projects-issues]

Juergen Hoeller commented

Hibernate 4.0 changed critical signatures in the Hibernate API, such as currentSession() and openSession() which have a different return type now (org.hibernate.Session instead of org.hibernate.classic.Session). For that reason, no Hibernate 3 support classes (from the orm.hibernate3) package are going to work against Hibernate 4.0.

So if you'd like a HibernateInterceptor variant, we'd have to provide a specific one for Hibernate 4.0 in the orm.hibernate4 package. What specifically are you using HibernateInterceptor for? It became rather uncommon to see that one in practice, which is why we omitted it from orm.hibernate4 for the time being...

Juergen

[spring-projects-issues]

Per Edlund commented

Hi Juergen!

We're currently using hibernate interceptor for 2 reasons. One is that we access DAO's from different thread's and in some cases from constructors. Another reason is that we're using JMS and in onMessage we just use the dao's without any session/tx- handling. For us it's really a convenient way of always being sure that the session is bound when accessing the dao's.

Do you understand my reason ?

[spring-projects-issues]

Daniel Geske commented

Same problem here with the missing HibernateInterceptor in the orm.hibernate4 package, though I have a different reason to use it.
I was working on a Quartz job which should lazy load related objects when I hit this road block using Spring 3.1 and Hibernate 4.

[spring-projects-issues]

Daniel Geske commented

FYI I solved my problem by adding the @Transactional annotation to the method the scheduled job executes.

[spring-projects-issues]

Raymond DeCampo commented

I also had found a need for the HibernateInterceptor. I am using it in MDB as well as in LoginManager configurations. If there is a work-around I would be interested in hearing it.

[spring-projects-issues]

PanosZhu commented

I think this is a very important function. I need it. I am using it both in tcp and http protocol. And also using it in scheduled job.

[spring-projects-issues]

thomas houtekier commented

I am also interested in this feature. Is there a known workaround for know?

[spring-projects-issues]

Andres Olave commented

Hi there guys,

I really needed HibernateInterceptor since encountering a hibernate bug that was only fixed in version 4.x. And we, rightly or wrongly, use HibernateInterceptor all over the place (Mdb's, business logic services, our one-page Widget Web framework 'services', and event processing).

So I took the old one and very pragmatically made it to work with Hibernate 4 for our uses. This is now on our test servers and looks like its holding up quite nicely.

Note it does not currently support hibernate filters as we have no need for these - but if anyone else would like to renable them and test it, I am sure your fellow spring user's will be grateful.

[spring-projects-issues]

Pawel Omelko commented

Do you already know if this class (HibernateInterceptor) will be available in hibernate4 package? This issue was create almost years ago.

It's very useful during working with Quartz triggered jobs, but @Transactional is not quite substitute.

[spring-projects-issues]

Pawel Omelko commented

Hi Andreas, Any problems with yours HibernateInterceptor implementation? I think about use it in my project.

[spring-projects-issues]

Pawel Omelko commented

Hello Juergen,

Any progress in this case?

If we already have some OpenSession class for http thread it will be nice to have one for not http thread (like Quartz workers).

What do you think about adding some kind of @OpenSession annotation, which can bind/unbind session to thread like HibernateInterceptor use to (using aspectj of course :))?

[spring-projects-issues]

Amit Mahindrakar commented

Hello Juergen,

Has there been any progress in this case?

[spring-projects-issues]

Juergen Hoeller commented

FYI, we introduced a HibernateTemplate variant for Hibernate 4 in Spring 4.0.1. However, there's still no HibernateInterceptor there since we ultimately would prefer to get rid of it completely.

If there is still interest in this, could you please summarize your HibernateInterceptor use cases including your specific HibernateInterceptor configuration (flush mode, filter names, etc).

We generally prefer transactional execution in combination with programmatic Hibernate access, but well, we would like to have a proper migration strategy for existing HibernateInterceptor usage...

Juergen

[spring-projects-issues]

Raymond DeCampo commented

We are using a simplified version of the HibernateInterceptor attached to this bug report (without the flush mode). We use it to provide a Hibernate session in environments outside of the web container. Specifically, in a custom javax.security.auth.spi.LoginModule implementation as well as in message-driven beans.

[spring-projects-issues]

Per Edlund commented

Hi!

We no longer use the HibernateInterceptor. We started with having the platform transaction manager as a field, and then using that to start the transaction if accessed from a thread or the constructor.

So for us, it's fine to skip it.