ConversionServiceFactory.addDefaultConverters() should add symetric converters [SPR-8306]

[spring-projects-issues]

Oliver Drotbohm opened SPR-8306 and commented

ConversionServiceFactory.addDefaultConverters() adds a few converters to convert from String to a particular type (e.g. Boolean, Character, Locale and so on). To convert those types back it adds an ObjectToStringConverter. This causes trouble as if you unregister this converter (in case you want to prevent any object to be convertible to a String without an explicit converter being added) you lose the ability to convert from and to those simple types as well.

I think we should have explicit converters for the simple types and use ObjectToStringConverter only as fallback for types that don't have explicit converters registered.

---

Affects: 3.0.5, 3.1 M1

Issue Links:

• DATAMONGO-130 Problem with Converters (java.util.Locale)

Referenced from: commits e25fbf2

[spring-projects-issues]

Oliver Drotbohm commented

Hi Keith, if it's okay for you I'd like to fix it for the RC. I didn't find the time to implement the fix on Friday and feel like it's not a good idea to quickly push it into the release and potentially sacrifice quality. From a Spring Data usage point of view we probably won't refer to core Spring 3.0 unless it's in an RC state at least.

[spring-projects-issues]

Keith Donald commented

O,
Went ahead and resolved this. Can you review and let me know if this meets your needs? Thanks.

[spring-projects-issues]

Oliver Drotbohm commented

That was a quick one :). Looks great at a first glance. I'll create a 3.1 branch in Spring Data Mongo to check whether that entirely solves the issue for us. Will let you know. Might mark this as fixed for M2 then…