Cache support - extend key features [SPR-8007]

[spring-projects-issues]

andrei acsinia opened SPR-8007 and commented

Beside methodName should be nice to have exposed 'package name', 'class name', 'parameters names', 'parameters as array'.
I consider very helpfully to have the opportunity build a key like: @Cacheable(value = "cacheName", key = "'#root.package + #root.methodName + #paramsName + #p0 + #p3)

---

Affects: 3.1 M1

Issue Links:

• Allow target access in Cache Key SpEL [SPR-7832] #12488 Allow target access in Cache Key SpEL

[spring-projects-issues]

andrei acsinia commented

Also i consider usefully for debug purposes:

public Object get(Object key) {
Element element = cache.get(key);
if (isDebugEnabled) {
if (isTraceEnabled) {
logger.trace("GET cache-name:" + getName() + " key:" + key + " element:" + element);
} else {
logger.debug("GET cache-name:" + getName() + " key:" + key);
}
}

return (element != null ? element.getObjectValue() : null);

}

public Object put(Object key, Object value) {
if (isDebugEnabled) {
if (isTraceEnabled) {
logger.trace("GET cache-name:" + getName() + " key:" + key + " value:" + value);
} else {
logger.debug("PUT cache-name:" + getName() + " key:" + key);
}
}
Element previous = cache.getQuiet(key);
cache.put(new Element(key, value));
return (previous != null ? previous.getValue() : null);
}

[spring-projects-issues]

Costin Leau commented

Fixed in trunk - most (all?) of the invocation objects are exposed as they are (such as the target method).
Added some logging as well in the cache aspect. For cache implementations, consider enabling this through the actual backing library.