Process @ImportResource with current ResourceLoader [SPR-7973]

[spring-projects-issues]

Keith Donald opened SPR-7973 and commented

I found the following odd with @ImportResource usage:

1. The @ImportResource ResourceLoader does not appear to be the same ResourceLoader as the ApplicationContext. I am using a AnnotationConfigWebApplicationContext, and I got classpath-relative resources by default.

2. Configuration-class relative resource resolution does not work, and one might expect it to. For example, if I import @ImportResource("mvc-interceptors.xml") from the com.springsource.greenhouse.config.mvc package, I'd expect "mvc-interceptors.xml" to be in that package, and not the root of the classpath. Having to specify "com/springsource/greenhouse/config/mvc/mvc-interceptors.xml" is a lot more to type and feels strange.

---

Affects: 3.1 M1

Attachments:

• mylyn-context.zip (26.03 kB)

Issue Links:

• Dependency injection not supported on @FeatureConfiguration classes [SPR-7975] #12630 Dependency injection not supported on @FeatureConfiguration classes

Referenced from: commits 4cdb04a

[spring-projects-issues]

Keith Donald commented

FWIW wrt to #1, I actually prefer classpath resource loading by default, since I prefer to store imported xml resources together with the Java Config classes they represent in the case where @ImportResource is used to support a hybrid config model (another reason support for package relative loading would come be a welcome addition). In the case where I actually import XML-driven application functionality, like Spring Integration usage e.g. integration-signup.xml, I'll qualify the resource location e.g. /com/springsource/greenhouse/signup/integration-signup.xml.

[spring-projects-issues]

Chris Beams commented

Keith,

Good point regarding #1. I've reworked things so that the BeanDefinitionReader implementation specified by @ImportResource will be delegated the application context's ResourceLoader immediately after instantiation if possible (i.e.: if the BeanDefinitionReader is an implementation of AbstractBeanDefinitionReader, which exposes a setResourceLoader() method).

Regarding #2, it's a duplicate of #10976. Check it out & comment if you see anything missing.