CronTrigger causes StackOverflowError [SPR-7807]

[spring-projects-issues]

Barry Lagerweij opened SPR-7807 and commented

Cron based triggers sometimes cause a StackOverflowError:

INFO | jvm 1 | 2010/12/08 22:44:29 | java.lang.StackOverflowError
INFO | jvm 1 | 2010/12/08 22:44:29 | at sun.util.calendar.ZoneInfo.getOffsets(Unknown Source)
INFO | jvm 1 | 2010/12/08 22:44:29 | at sun.util.calendar.ZoneInfo.getOffsets(Unknown Source)
INFO | jvm 1 | 2010/12/08 22:44:29 | at java.util.GregorianCalendar.computeFields(Unknown Source)
INFO | jvm 1 | 2010/12/08 22:44:29 | at java.util.GregorianCalendar.computeTime(Unknown Source)
INFO | jvm 1 | 2010/12/08 22:44:29 | at java.util.Calendar.updateTime(Unknown Source)
INFO | jvm 1 | 2010/12/08 22:44:29 | at java.util.Calendar.complete(Unknown Source)
INFO | jvm 1 | 2010/12/08 22:44:29 | at java.util.Calendar.get(Unknown Source)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:126)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:148)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:139)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:164)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:139)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:148)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:139)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:164)
INFO | jvm 1 | 2010/12/08 22:44:29 | at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:139)
.......
(deleted a lot of lines from the trace)

---

Affects: 3.0 GA

Issue Links:

• Cron expressions use months based at 0-11 (should be 1-12) [SPR-7384] #12042 Cron expressions use months based at 0-11 (should be 1-12)

Referenced from: commits cee6cb8, 28e6d9a

[spring-projects-issues]

Barry Lagerweij commented

This is the cron expression: "0 30 23 30 1/3 ?"

[spring-projects-issues]

Stevo Slavić commented

I've managed to reproduce this unwanted behavior (with StackOverflowError) by adding extra test [1] to CronTriggerTests in latest sources but with revision 3489 reverted ("SPR-7384: switch to using 1-12 for month numbers" change). That change is labeled as fixed for 3.0.4, and it seems wrong version is reported as affected version in this ticket. Running same test on latest sources with rev3489 included, test passes successfully. IMO this issue is fixed with #12042 and rev3489 changes.

@Test
public void testMonthSequence() throws Exception {
     CronTrigger trigger = new CronTrigger("0 30 23 30 1/3 ?", timeZone);
     calendar.set(2010, 11, 30);
     Date date = calendar.getTime();
     // set expected next trigger time
     calendar.set(Calendar.HOUR_OF_DAY, 23);
     calendar.set(Calendar.MINUTE, 30);
     calendar.set(Calendar.SECOND, 0);
     calendar.add(Calendar.MONTH, 1);
     TriggerContext context1 = getTriggerContext(date);
     assertEquals(calendar.getTime(), date = trigger.nextExecutionTime(context1));
     // Next trigger is 3 months latter
     calendar.add(Calendar.MONTH, 3);
     TriggerContext context2 = getTriggerContext(date);
     assertEquals(calendar.getTime(), date = trigger.nextExecutionTime(context2));
     // Next trigger is 3 months latter
     calendar.add(Calendar.MONTH, 3);
     TriggerContext context3 = getTriggerContext(date);
     assertEquals(calendar.getTime(), date = trigger.nextExecutionTime(context3));
}

[spring-projects-issues]

Juergen Hoeller commented

Thanks, Stevo - I've added that test to our test suite, and it does indeed pass against recent Spring versions as expected.

Juergen

[spring-projects-issues]

Barry Kaplan commented

I am seeing this with 3.2.3. Not details yet, all I have is the stack trace:

2013-07-31 01:29:53,845 ERROR c.e.e.c.s.ResultDeliveryStrategyImpl - Invocation exception when invoking method 'update' of class 'systeminsights.infra.esper.EsperStatements$EPStatementW$SubscriberFunction1' passing parameters [2152085999930] for statement 'ScheduleDowntimeRule: state=false--1': StackOverflowError : null | deviceUUID=, tenant=tft [vimana-vimana.devices-dispatcher-26] 
java.lang.StackOverflowError: null
	at sun.util.calendar.AbstractCalendar.getCalendarDate(AbstractCalendar.java:165) ~[na:1.7.0_25]
	at sun.util.calendar.Gregorian.getCalendarDate(Gregorian.java:73) ~[na:1.7.0_25]
	at sun.util.calendar.Gregorian.getCalendarDate(Gregorian.java:37) ~[na:1.7.0_25]
	at java.util.SimpleTimeZone.getOffsets(SimpleTimeZone.java:562) ~[na:1.7.0_25]
	at java.util.SimpleTimeZone.getOffset(SimpleTimeZone.java:539) ~[na:1.7.0_25]
	at sun.util.calendar.ZoneInfo.getOffsets(ZoneInfo.java:308) ~[na:1.7.0_25]
	at sun.util.calendar.ZoneInfo.getOffsets(ZoneInfo.java:248) ~[na:1.7.0_25]
	at java.util.GregorianCalendar.computeFields(GregorianCalendar.java:2276) ~[na:1.7.0_25]
	at java.util.GregorianCalendar.computeTime(GregorianCalendar.java:2753) ~[na:1.7.0_25]
	at java.util.Calendar.updateTime(Calendar.java:2606) ~[na:1.7.0_25]
	at java.util.Calendar.complete(Calendar.java:1558) ~[na:1.7.0_25]
	at java.util.Calendar.get(Calendar.java:1162) ~[na:1.7.0_25]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:146) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:159) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]
	at org.springframework.scheduling.support.CronSequenceGenerator.doNext(CronSequenceGenerator.java:168) ~[spring-context-3.2.3.RELEASE.jar:3.2.3.RELEASE]