Returning EmptyHolder from Cache causes ClassCastException [SPR-7736]

[spring-projects-issues]

Chris Bonham opened SPR-7736 and commented

In the CacheAspectSupport class, if an EmptyHolder object is returned from the Cache, a ClassCastException can occur if the calling method expects a different type of object. I have created a patch that returns null if the EmptyHolder is returned. The check uses the EmptyHolder class since the actual EmptyHolder object could be from a separate JVM so an identity comparision with NULL_OBJECT won't work.

---

Affects: 3.1 M1

Attachments:

• EmptyHolder.patch (750 bytes)

Referenced from: commits 8285e9c

[spring-projects-issues]

Costin Leau commented

Thanks for the feedback. I've changed the way we store nulls - basically it's up to the cache implementation to decide how to go around it since it's the store that dictates the strategy and whatever we try to come up with can be either: low-performing or simply wrong (assume the store does an actual type check).