SqlParameter name lower case conversion in CallMetaDataContext causes error. [SPR-7658]

[spring-projects-issues]

Abdurrahman Sahin opened SPR-7658 and commented

There is a lower case conversion in the following function of CallMetaDataContext.

I think lower case conversion is unnecassary or should be revised.
I have Oracle 10g+Tomcat 6 + JDK 6.0.12 environment
Oracle database NLS_LANG is Turkish_Turkey
Regional Settings is set to Turkey.
by default oracle db keeps object names in uppercase.

a procedure parameter named INSTITUTION is converted to "ınstıtutıon" (please note there isn't dot ) by CallMetaDataContext, then procedure call with parameter name "ınstıtutıon" fails, since parameter named "ınstıtutıon" is not found.

The whole problem is caused by ignoring following Turkish case conversion rule.

The turkish letter "I" is represended in lower case as "ı" (without dot)
The turkish letter "İ" (with dot above) is represended in lower case as "i" (with dot)
The turkish letter "I" and "İ" are not the same.
The turkish letter "ı" and "i" are not the same.

As a sequence I think case conversion should not be done for parameter matching.

public Map<String, Object> matchInParameterValuesWithCallParameters(Map<Strin g, Object> inParameters)

---

Affects: 2.5 final

Reference URL: http://forum.springsource.org/showthread.php?t=96819

Attachments:

• log.txt (3.20 kB)
• log2.txt (30.67 kB)
• reg_settings1.JPG (41.37 kB)

[spring-projects-issues]

Abdurrahman Sahin commented

Related component should be SpringCore not SpringAOP

[spring-projects-issues]

Juergen Hoeller commented

Thomas, is there maybe a chance for you to look at this today - in time for 3.0.5? We intend to take the release cut this evening... If this is easy enough to sort out, it would be great to have in 3.0.x still; otherwise it'll have to wait for 3.1.

Juergen

[spring-projects-issues]

Thomas Risberg commented

Can you provide a Java code example where this happens.

-Thomas

[spring-projects-issues]

Thomas Risberg commented

Could you also run with logging level of TRACE for org.springframework.jdbc and attach that log? That would make it easier to figure this out.

Thanks,
Thomas

[spring-projects-issues]

Abdurrahman Sahin commented

Atttached is a trace level log file.
I can provide a java example on Monday if it's still required.

abdurrahman sahin

[spring-projects-issues]

Thomas Risberg commented

I think I know what is happening - I added and additional test using lowercase with Locale.ENGLISH and that worked for my test case. It's committed and you can try the next snapshot or the 3.0.5 release that should be out any day.

-Thomas