PropertyPlaceholderHelper#findPlaceholderEndIndex does not work for custom placeholderPrefix [SPR-7574]

[spring-projects-issues]

Matt Kusnierz opened SPR-7574 and commented

The logic is incorrect within the findPlaceholderEndIndex method:

version 3.0.1 line 173
version 3.0.4 line 193

index = index + this.placeholderPrefix.length() - 1;

I think this line should read:

index = index + this.placeholderSuffix.length();

The code as it stands only works at the moment because the default prefix "${" is 2 characters and the default suffix "}" is 1 character.

---

Affects: 3.0.4

Reference URL: http://forum.springsource.org/showthread.php?t=95476

Attachments:

• PropertyPlaceholderHelper-3.0.1.RELEASE-A.java (7.85 kB)
• PropertyPlaceholderHelper-3.0.4.RELEASE.java (8.37 kB)
• SpringPropertyPlaceholderHelper-3.0.1.RELEASE-A.jar (3.66 kB)

Referenced from: commits eda6268

[spring-projects-issues]

Juergen Hoeller commented

Good catch! Fixed for 3.0.5.

Juergen