Improve exception handling in PropertyPlaceholderConfigurer [SPR-7510]

[spring-projects-issues]

Kenny MacLeod opened SPR-7510 and commented

The processProperties() method of PropertyPlaceholderConfigurer has a catch-all for any Exception thrown by the visitor. The exception's message is extracted and passed to a re-thrown BeanStoreDefinitionException. However, the remainder of the original exception (including any stack trace) is lost.

This is a problem for unhelpful exceptions like NullPointerException where the exception message is useless.

Can the original exception be preserved, either by passing it as the root cause of the BeanStoreDefinitionException, or using a log-and-rethrow?

---

Affects: 3.0.4

[spring-projects-issues]

Oliver Drotbohm commented

We could fix this by simply using another constructor of BeanDefinitionStoreException to either replace handing the original exception message with handing the exception itself or hand the original exception additionally to its message. However I wonder if there's some rational behind currently not doing so. If not, feel free to assign it to me to actually fix it (@Chris).

Regards,
Ollie

[spring-projects-issues]

Chris Beams commented

Sounds quite reasonable; go ahead Ollie, thanks.

[spring-projects-issues]

Oliver Drotbohm commented

Fixed in a local branch. Waiting for 3.0.5 release to check in that stuff afterwards.