Optional @RequestParam with required=false no longer works in Spring 3.0.4 (compared to 3.0.2) when Controller extends interface [SPR-7483]

[spring-projects-issues]

Grant Gochnauer opened SPR-7483 and commented

In order to work around CGLIB and AOP memory issues all of our MVC controllers extend Interfaces for proxying.

We have something like this in our interface:

@RequestMapping(value = "/contactus.htm", method = RequestMethod.POST)
 ModelAndView handleContactUsSubmit(HttpServletRequest request, HttpServletResponse response,
                                    @RequestParam(value = "pUrl", required = false) String promotionUrl, @ModelAttribute ContactUsModel model,
                                    Errors errors);

And in the class:

@ExposeSharedPageAttributes
    public ModelAndView handleContactUsSubmit( HttpServletRequest request, HttpServletResponse response, @RequestParam(value = "pUrl", required = false) String promotionUrl, @ModelAttribute ContactUsModel model,
            Errors errors )
    {

This worked great in Spring 3.0.2. After upgrading to 3.0.4, I receive the following stack trace:

Caused by: org.springframework.web.bind.annotation.support.HandlerMethodInvocationException: Failed to invoke handler method [public final org.springframework.web.servlet.ModelAndView $Proxy100.handleContactUsSubmit(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse,java.lang.String,com.roche.cwp.web.template.contactus.model.ContactUsModel,org.springframework.validation.Errors)]; nested exception is java.lang.IllegalStateException: No parameter name specified for argument of type [java.lang.String], and no parameter name information found in class file either.
	at org.springframework.web.bind.annotation.support.HandlerMethodInvoker.invokeHandlerMethod(HandlerMethodInvoker.java:181)
	at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.invokeHandlerMethod(AnnotationMethodHandlerAdapter.java:427)
	at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.handle(AnnotationMethodHandlerAdapter.java:415)
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:788)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:717)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:644)
	... 81 more
Caused by: java.lang.IllegalStateException: No parameter name specified for argument of type [java.lang.String], and no parameter name information found in class file either.
	at org.springframework.web.bind.annotation.support.HandlerMethodInvoker.getRequiredParameterName(HandlerMethodInvoker.java:731)
	at org.springframework.web.bind.annotation.support.HandlerMethodInvoker.resolveRequestParam(HandlerMethodInvoker.java:480)
	at org.springframework.web.bind.annotation.support.HandlerMethodInvoker.resolveHandlerArguments(HandlerMethodInvoker.java:340)
	at org.springframework.web.bind.annotation.support.HandlerMethodInvoker.invokeHandlerMethod(HandlerMethodInvoker.java:171)
	... 86 more

---

Affects: 3.0.4

Referenced from: commits 284f98f

1 votes, 5 watchers

[spring-projects-issues]

Grant Gochnauer commented

This is in Websphere 6.1 with JDK5

[spring-projects-issues]

Grant Gochnauer commented

In my spring servlet xml, I have this defined:

<aop:aspectj-autoproxy proxy-target-class="false"/>

[spring-projects-issues]

Grant Gochnauer commented

If I change <aop:aspectj-autoproxy proxy-target-class="false"/> to <aop:aspectj-autoproxy proxy-target-class="true"/> - everything works OK but now we're back to using CGLIB and a much larger memory footprint.

[spring-projects-issues]

Juergen Hoeller commented

This turned out as a regression caused by the fix for #11985. Fixed for 3.0.5 now to accommodate both scenarios.

Feel free to give tonight's 3.0.5 snapshot a try, and let me know whether it works for you...

Juergen

[spring-projects-issues]

Grant Gochnauer commented

Thank you! :)

[spring-projects-issues]

Grant Gochnauer commented

Confirmed fixed in: spring-framework-3.0.5.CI-804

[spring-projects-issues]

Ritesh commented

The exception reappeared as soon as I replaced Spring 3.0.5 jar files with 3.1 M2 jar files.

[spring-projects-issues]

Ritesh commented

I get this exception after upgrading to 3.1 M2:

java.lang.IllegalArgumentException: Name for argument type [java.lang.String] not available, and parameter name information not found in class file either.
at org.springframework.util.Assert.notNull(Assert.java:112)
at org.springframework.web.method.annotation.support.AbstractNamedValueMethodArgumentResolver.updateNamedValueInfo(AbstractNamedValueMethodArgumentResolver.java:133)
at org.springframework.web.method.annotation.support.AbstractNamedValueMethodArgumentResolver.getNamedValueInfo(AbstractNamedValueMethodArgumentResolver.java:111)
at org.springframework.web.method.annotation.support.AbstractNamedValueMethodArgumentResolver.resolveArgument(AbstractNamedValueMethodArgumentResolver.java:80)
at org.springframework.web.method.support.HandlerMethodArgumentResolverComposite.resolveArgument(HandlerMethodArgumentResolverComposite.java:65)
at org.springframework.web.method.support.InvocableHandlerMethod.getMethodArgumentValues(InvocableHandlerMethod.java:153)
at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:117)
at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:100)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:502)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:465)
at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:80)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:863)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:792)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:851)
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:767)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)

[spring-projects-issues]

Ralph Schaer commented

I got the same exception after upgrading from 3.1M1 to 3.1M2.
"java.lang.IllegalArgumentException: Name for argument type [java.lang.String] not available, and parameter name information not found in class file either.

This is the controller class that has the problem.

@Controller
public class CustomerInfoController {
...
@RequestMapping(value = "/customerInfo", method = RequestMethod.GET)
@Transactional(readOnly = true)
@ResponseBody
public Map<String, Object> customerInfo(@RequestParam(value = "cid", required = false) String customerId) {
...
}
...
}

It works if I remove the @Transactional annotation.
Looks like M2 has a problem with proxied methods.

[spring-projects-issues]

Emmanuel Venisse commented

As explained in above comments, this issue is present into 3.1 M2

[spring-projects-issues]

Juergen Hoeller commented

Rossen, this is probably an issue with our refactored RequestMethodHandlerAdapter. It was broken and got fixed in 3.0.x but apparently reappeared in 3.1 M2.

Juergen

[spring-projects-issues]

Rossen Stoyanchev commented

A fix related to class-proxied controllers was added after 3.1 M2 (#13110). Both interface and class-based proxying should work with the latest code. Emmanuel, Ralph, and Ritesh would you mind giving 3.1.0.BUILD-SNAPSHOT a try? The maven repository is http://maven.springframework.org/snapshot.

[spring-projects-issues]

Emmanuel Venisse commented

ok, it is fixed in 3.1.0.BUILD-SNAPSHOT, thanks

[spring-projects-issues]

Rossen Stoyanchev commented

Okay thanks for confirming. It sounds like the issue noticed in 3.1 M2 is addressed but feel free to reopen if not. It was a problem with proxying controllers (rather than controllers with interfaces). Ralph's code sample above confirms that as well.

[spring-projects-issues]

Marnel J. Rodriguez commented

I am on 3.0.5.RELEASE and below is my interface code.

@PreAuthorize("hasAuthority('PERM_DOCTORS_NOTES_CREATE')")
@RequestMapping(value = "/patient/{pin}/doctors-notes/action", method = RequestMethod.POST, params = "draftBtn")
ModelAndView saveDraft(@PathVariable("pin") long pin,
@RequestParam(value = "formKey") String formKey,
@ModelAttribute(WebFormSupport.FORM_NAME) FormResultDto formResult, BindingResult result,
HttpSession httpSession, HttpServletRequest request);

And still I get the error below.

Handler execution resulted in exception org.springframework.web.bind.annotation.support.HandlerMethodInvocationException: Failed to invoke handler method [public abstract org.springframework.web.servlet.ModelAndView com.tmc.emr.web.template.docnotes.controller.DoctorsNotesActionController.saveDraft(java.lang.String,com.tmc.emr.workflow.model.FormResultDto,org.springframework.validation.BindingResult,javax.servlet.http.HttpSession,javax.servlet.http.HttpServletRequest)]; nested exception is java.lang.IllegalStateException: No parameter name specified for argument of type [java.lang.String], and no parameter name information found in class file either.

If I remove the security context to disable the @PreAuthorize annotation, everything works well. But with the security context enabled. I get that error. My viewResolver is org.springframework.web.servlet.view.velocity.VelocityViewResolver