SpringTemplateLoader returns -1 for lastModified which breaks caching [SPR-7454]

[spring-projects-issues]

Michael Wyraz opened SPR-7454 and commented

org.springframework.ui.freemarker.SpringTemplateLoader.getLastModified() returns -1. This prevents Freemarker from detecting template changes. Is simply should return resource.lastModified().

---

Affects: 2.5.6

Referenced from: commits 9bd0bd9

[spring-projects-issues]

Juergen Hoeller commented

This was actually documented as a limitation in SpringTemplateLoader's javadoc. Also, back in 2005, the Resource abstraction did not have last-modified support yet.

In any case, now in Spring 3.0, we can certainly support last-modified for FreeMarker templates as well. Fixed for 3.0.4, scheduled for release next week.

Juergen

[spring-projects-issues]

Michael Wyraz commented

Is there a chance for a backport to spring 2.5.x?

[spring-projects-issues]

Juergen Hoeller commented

I'm afraid not, since Spring 2.5.x is in strict maintenance mode. What you can do with 2.5.x is to create a custom subclass of FreeMarkerConfigurer and override the getTemplateLoaderForPath method to return a subclass of SpringTemplateLoader which in turn adds getLastModified support. This is fully supported from a Spring perspective and equivalent to the solution in Spring 3.0.4.

That said, you could of course also upgrade to Spring 3.0.4 right away. For many Spring 2.5.6 based applications, this is basically a drop-in replacement, as long as you are running on Java 5+. Even if you're using some classes which got deprecated in Spring 3.0, they'll keep working; you may migrate to Spring 3.0's recommended alternatives at a later point of time.

Juergen