PropertyResourceConfigurer.convertPropertyValue should also include propertyName in the method signature for better handling of property value conversion [SPR-7386]

[spring-projects-issues]

Faisal Feroz opened SPR-7386 and commented

The current signature of PropertyResourceConfigurer.convertPropertyValue is:
protected String convertPropertyValue(String originalValue)

This should also include the "property name" as well so that the overriding method can do a better job of converting property values instead of deducing the conversion logic from the property value.

For example if the values are encrypted for certain properties, a simple check can be coded based on the property names instead of deducing if the value is encrypted or not from the property value.

---

Referenced from: commits 4d5a9c4

[spring-projects-issues]

Juergen Hoeller commented

Good point! I've added a corresponding convertProperty(String propertyName, String propertyValue) method to PropertyResourceConfigurer, which in turn delegates to convertPropertyValue by default.

Juergen