o.s.http.client.SimpleClientHttpRequestFactory does not allow to specify a java.net.Proxy [SPR-7305]

[spring-projects-issues]

Cédrik LIME opened SPR-7305 and commented

While working with the new ClientHttpRequestFactory, I need to create an outgoing HTTP connection via a proxy.
ClientHttpRequestFactory has 2 implementations: commons-http and simple (Java native).
While I can specify a proxy using CommonsClientHttpRequestFactory (it exposes the HttpClient instance), this is not true of SimpleClientHttpRequestFactory.

To fix this problem, you need to externalise the 1st line of SimpleClientHttpRequestFactory#createRequest(URI, HttpMethod) so that we can subclass uri.toURL().openConnection() to read uri.toURL().openConnection(someProxy) when needed.

---

Affects: 3.0.3

Referenced from: commits c059f53

[spring-projects-issues]

Arjen Poutsma commented

Done, the SimpleClientHttpRequestFactory now has a Proxy property.

I've also added o.s.http.client.support.ProxyFactoryBean, to allow for easier configuration of java.net.Proxy in Spring XML app contexts.