TypeMismatchException instead of IllegalArgumentException: argument type mismatch for wrong RequestBody [SPR-7263]

[spring-projects-issues]

Gerrit Brehmer opened SPR-7263 and commented

If a controller method is called with a wrong (but for message converter known type) @RequestBody message, an java internal reflection exception will be raised: java.lang.IllegalArgumentException: argument type mismatch.

It would be nice, if a Spring-TypeMismatchException exception could be raised instead (so a type check is needed). This exception is already mapped to a 400 Bad Request. With IllegalArgumentException the cause of the exception is not exactly enough.

---

Affects: 3.0.2

Attachments:

• SPR7263Tests.java (1.95 kB)

Referenced from: commits 65885d1, 723f94f

[spring-projects-issues]

Arjen Poutsma commented

I'm having difficulties reproducing this issue. Can you illustrate when this issue occurs? Specifically, I'm interested in the @Controller method signature, and the payload (content-type and contents) that triggers this behavior. It would be great if you could attach a unit test that reproduces this, but it's not strictly necessary.

[spring-projects-issues]

Gerrit Brehmer commented

Controller:

@RequestMapping(value="/customer/{id}/address", method = RequestMethod.PUT)
@ResponseStatus(value = HttpStatus.NO_CONTENT)
public void changeAddress(@PathVariable("id") Long id, @RequestBody Address address, HttpServletRequest request) {
}

@RequestMapping(value="/customer/{id}/bankaccount", method = RequestMethod.PUT)
@ResponseStatus(value = HttpStatus.NO_CONTENT)
public void changeBankAccount(@PathVariable("id") Long id, @RequestBody BankAccount bankAccount, HttpServletRequest request) {
}

If I call "customer/123/bankaccount" with an address-instances as xml payload, the Payload will be converted by the MessageConverter but is the wrong type for function call. The MarshallingHttpMessageConverter is not using provided requestbody class type instead of other HttpMessageConverter.

Http-Request:

PUT /app/customer/38961805/address HTTP/1.1
Content-Length: 27
Content-Type: application/xml 

<bankAccount></bankAccount>

Spring-config:

<bean
     class="org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter">
     <property name="messageConverters">
          <list>
               <ref bean="marshallingHttpMessageConverter" />
          </list>
     </property>
</bean>
<bean id="marshallingHttpMessageConverter"
     class="org.springframework.http.converter.xml.MarshallingHttpMessageConverter">
     <property name="marshaller" ref="marshaller"></property>
     <property name="unmarshaller" ref="marshaller"></property>
</bean>
<bean id="marshaller" class="org.springframework.oxm.jaxb.Jaxb2Marshaller">
     <property name="classesToBeBound" ref="jaxbxmlrootlist" />
</bean>

I have more time tonight and can then provide a unittest.

[spring-projects-issues]

Gerrit Brehmer commented

Attached a unittest. During the configuration of the test i saw, that Jaxb2RootElementHttpMessageConverter unlike MarshallingHttpMessageConverter throws the right exception (MessageNotReadable), because it creates a new JAXBContext/Marshaller for each request, which only supports the type of the @RequestBody method parameter.

[spring-projects-issues]

Arjen Poutsma commented

Thanks for the unit test! That certainly helps.

[spring-projects-issues]

Arjen Poutsma commented

Fixed now. The unit test really helped, thanks for that!