Potential null-pointer in TransactionAspectSupport.determineTransactionManager() [SPR-7153]

[spring-projects-issues]

Oliver Drotbohm opened SPR-7153 and commented

The logic in TransactionInterceptor.invoke(...) retrieves TransactionAttribute from a TransactionAttributeSource which according to the API can be null. determineTransactionManager of the super class then accesses txAttr.getQualifier() without a null check. The qualifier can be simply null in case txAttr is null.

---

Affects: 3.0.2

Issue Links:

• @Transactional qualifier is ignored by TransactionAspectSupport if default transaction manager is set [SPR-12541] #17145 @Transactional qualifier is ignored by TransactionAspectSupport if default transaction manager is set ("is depended on by")

Referenced from: commits b0afa0c

[spring-projects-issues]

Juergen Hoeller commented

Well spotted. Fixed for 3.0.3, only retrieving the transaction manager when actually necessary now. We can't just fall back to a null qualifier in that case either since we may fail to find a default transaction manager bean... It's safer to simply not retrieve a transaction manager bean in the first place then, since it won't be used anyway.

Juergen