Proxy created for intercept-methods doesn't respect autowire-candidate attribute [SPR-6974]

[spring-projects-issues]

Wouter Coekaerts opened SPR-6974 and commented

When using intercept-methods in a bean definition with autowire-candidate="false", the created proxy is still a candidate for autowiring.

Attached a sample to reproduce the problem.

This is the same problem as was fixed for aop:scoped-proxy in #8484.

---

Affects: 3.0.1

Attachments:

• autowire-test.zip (2.22 kB)

Referenced from: commits d4de1ac

[spring-projects-issues]

Luke Taylor commented

Again, I'm not sure that this is a Spring Security issue, as the proxy is created by AbstractInterceptorDrivenBeanDefinitionDecorator, which replaces the original bean with the proxy. At that point, it should copy the flag from the existing bean:

RootBeanDefinition proxyDefinition = new RootBeanDefinition();
proxyDefinition.setAutowireCandidate(proxyDefinition.isAutowireCandidate());

[spring-projects-issues]

Wouter Coekaerts commented

I'm not sure, but this part in Spring Security's InternalInterceptMethodsBeanDefinitionDecorator.createInterceptorDefinition looks suspicious to me:

// Default to autowiring to pick up after invocation mgr
interceptor.setAutowireMode(RootBeanDefinition.AUTOWIRE_BY_TYPE);

[spring-projects-issues]

Wouter Coekaerts commented

Ugh, sorry, nevermind that last comment (think before you comment, Wouter).

[spring-projects-issues]

Juergen Hoeller commented

AbstractInterceptorDrivenBeanDefinitionDecorator copies autowire settings just like ScopedProxyUtils does now. So this should be fixed for 3.0.2; we still need to test this with Spring Security, though.

Juergen