exotic MIME-Type leads to 500 Internal Server Error [SPR-6894]

[spring-projects-issues]

Andreas Schneider opened SPR-6894 and commented

Hello,

for an academic investigation I compare Java Frameworks for RESTful Web Services, e.g. Spring MVC.

The configuration file contains:
<property name="mediaTypes" >
<map>
<entry key="xml" value="application/xml"/>
<entry key="json" value="application/json"/>
</map>
</property>

To test content negotiation I do every method with an exotic MIME-Type (audio/x-liveaudio). So I filled the header Accept with that type.
For the methods GET, HEAD and DELETE I receive 500 Internal Server Error.
But I expected 406 Not Acceptable for GET/HEAD and 200 OK for DELETE.

With best regards
Andreas Schneider

---

Affects: 3.0 GA

Issue Links:

• Allow ContentNegotiatingViewResolver to be strict ant return a 406 if no view found [SPR-6467] #11133 Allow ContentNegotiatingViewResolver to be strict ant return a 406 if no view found ("duplicates")

[spring-projects-issues]

Arjen Poutsma commented

Can you please supply a stacktrace that goes with the Internal Server Error?

[spring-projects-issues]

Andreas Schneider commented

Hi Arjen,

here is the stacktrace you asked for.

23.02.2010 21:28:42 org.apache.catalina.core.StandardWrapperValve invoke
SCHWERWIEGEND: Servlet.service() for servlet springmvc threw exception
javax.servlet.ServletException: Could not resolve view with name 'customers' in servlet with name 'springmvc'
at org.springframework.web.servlet.DispatcherServlet.render(DispatcherServlet.java:1042)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:798)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:716)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:647)
at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:552)
at javax.servlet.http.HttpServlet.doHead(HttpServlet.java:241)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:634)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.springframework.web.filter.ShallowEtagHeaderFilter.doFilterInternal(ShallowEtagHeaderFilter.java:57)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:76)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:433)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454)
at java.lang.Thread.run(Unknown Source)

And here is the resource method for GET/HEAD, maybe you find that helpful:

@Controller
@RequestMapping(value = "/customers")
public class CustomerListController extends BaseController {

@RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD})
@ResponseStatus(value = HttpStatus.OK)
public CustomerService get(
@RequestParam(value = "name", required = false) String name,
@RequestParam(value = "forename", required = false) String forename)
throws CommonException {
return new CustomerBO(Framework.SPRINGMVC).getCustomerServiceByQueryParams(name, forename);
}
}

As you see, the method returns CustomerService. This class is annotated with @XmlRootElement.

With best regards
Andreas Schneider

[spring-projects-issues]

Arjen Poutsma commented

The issue here is that by default the ContentNegotiatingViewResolver returns null if it cannot find a view, in order to let other view resolvers try and find a matching view. If no view can be resolved, it results in the exception you've experienced.

That said, we've added a 'useNotAcceptableStatusCode' property in Spring 3.0.1. If you enable this property (the default is false), the ContentNegotiatingViewResolver returns a special 'NotAcceptableView' which sets the response status code to 406.

[spring-projects-issues]

Andreas Schneider commented

Thank you Arjen,
that worked fine for me.

Andreas Schneider