Url suffix after dot is omitted [SPR-6518]

[spring-projects-issues]

Ave Kar opened SPR-6518 and commented

Using @Pathvariable to pass in filenames omits the extension.

i.e.: If passing in /admin/documents/foo.txt

@RequestMapping("/admin/documents/{fileName}")
public void foo(@PathVariable String fileName)
{
// fileName will come in as 'foo' instead of 'foo.txt'
}

---

Affects: 3.0 M4, 3.0 RC1, 3.0 RC2, 3.0 RC3

Reference URL: http://forum.springsource.org/showthread.php?t=77491

Issue Links:

• Regression when using @RequestMapping, @PathVariable, and GenericConversionService [SPR-6483] #11149 Regression when using @RequestMapping, @PathVariable, and GenericConversionService
• PathVariables of type double [SPR-6528] #11194 PathVariables of type double

[spring-projects-issues]

Arjen Poutsma commented

By default, all @RequestMapping patterns are suffixed with .* So effectively, @RequestMapping("/admin/documents/{fileName}") will result in two patterns: /admin/documents/{filename} and /admin/documents/{filename}.*. And this last pattern "wins" when a request for /admin/documents/foo.txt comes in.

You can disable this behavior by explicitly configuring a DefaultAnnotationHandlerMapping in you servlet app context (thus overriding the default), and setting the 'useDefaultSuffixPattern' property to false (default is true).

[spring-projects-issues]

Ave Kar commented

Setting the useDefaultSuffixPattern property to false allows the return files as with extension but this forces using /admin/documents/{fileName}.{fileExtension} in the path since files HelloWorld.java do not map to the /admin/documents/{fileName} path. If the file does not have to have an extension i.e. HelloWorld then that won't map to /admin/documents/{fileName}.{fileExtension}.
This forces the user to have two separate requests that ultimately do the same thing for files that have extensions and files that don't. Will this be fixed in the next version so that all files are mapped to {fileName}?

[spring-projects-issues]

Arjen Poutsma commented

Yes. I've made some recent changes in the way uri template variables are matched, and HelloWorld.java now does map to the /admin/documents/{fileName}.

You could try a recent (as of yesterday) snapshot and see if it works for you.