Broken @RequestMapping inheritance [SPR-6502]

[spring-projects-issues]

Łukasz Dywicki opened SPR-6502 and commented

After switch from Spring 3.0.0 RC1 to Spring 3.0.0 RC3 my controlers stop working. Spring says:

No adapter for handler [org.code_house.spring3.web.UserControllerImpl@5a7691c0]: Does your handler implement a supported interface like Controller?

Test application (war, jar with sources) are available in Maven repository:
http://repository.code-house.org/content/repositories/code-house.internal.snapshot/org/code-house/spring3/test/1.0.0.SNAPSHOT/

Controller code:

package org.code_house.spring3.web;

import java.util.List;

import org.code_house.spring3.api.UserController;
import org.code_house.spring3.dao.api.UserDAO;
import org.code_house.spring3.domain.Group;
import org.code_house.spring3.domain.User;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Controller;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestMapping;

@Controller
@RequestMapping("/users")
public class UserControllerImpl extends GenericControllerImpl<User, Integer>
    implements UserController {

    private UserDAO daoImpl;

    public List<Group> listAssigns() {
        return daoImpl.listAssigns();
    }

    public boolean assign(@PathVariable Integer number) {
        daoImpl.assign(number);
        return Boolean.TRUE;
    }

    @Autowired
    public void setDaoImpl(UserDAO daoImpl) {
        setDao(daoImpl);
        this.daoImpl = daoImpl;
    }
}

---

Affects: 3.0 RC3

Attachments:

• spring.log (108.36 kB)

Issue Links:

• When looking up methods with @RequestMapping annotation, unannotated bridge methods are included [SPR-6206] #10874 When looking up methods with @RequestMapping annotation, unannotated bridge methods are included

Referenced from: commits 27e0642

[spring-projects-issues]

Arjen Poutsma commented

Can you please explain what HTTP request path you tried, and what method you expect to be invoked?

I'm guessing it's /users/assign/123 or something, and the expected method is assign, but it's better to be sure.

[spring-projects-issues]

Arjen Poutsma commented

Also, it would help if you could include the log (with DEBUG level enabled). It shows me what @Controller methods are considered, which pattern matches are executed, etc.

[spring-projects-issues]

Łukasz Dywicki commented

Yes, I use url:

http://localhost:8888/server/rest/users/assign/

But even first URL is not correctly handled by RC3.

URL below is broken due inconsistent parameter name in concrete class:

http://localhost:8888/server/rest/users/assign/1

[spring-projects-issues]

Łukasz Dywicki commented

Log file.

[spring-projects-issues]

Łukasz Dywicki commented

I created SVN repository with this application. You can easily download all source code and run it using maven from:
http://svn.code-house.org/spring3/trunk/

[spring-projects-issues]

Arjen Poutsma commented

I believe this functionality broke as part of fixing #10874.

[spring-projects-issues]

Arjen Poutsma commented

This should be fixed now. Could you try a recent snapshot (as of tonight)?

[spring-projects-issues]

Arjen Poutsma commented

One thing to note is that I needed to change

@RequestMapping(value = "/assign/")

to

@RequestMapping(value = "/assign")

(Note the missing slash)
in UserController. After that, your code works for me.