Provde setter for formatters in FormattingConversionServiceFactoryBean [SPR-6446]

[spring-projects-issues]

Sebastian Beigel opened SPR-6446 and commented

It would be nice to have convenience setters in FormattingConversionServiceFactoryBean to add custom formatters (and maybe converters and converter factories...). It's much easier to explicitly declare a <bean class="FormattingConversionServiceFactoryBean"> and customize it than to implement, declare and customize a FormatterRegistry.

---

Affects: 3.0 RC2

Issue Links:

• Make it easier to register custom Formatters [SPR-7732] #12388 Make it easier to register custom Formatters ("is superseded by")

[spring-projects-issues]

Keith Donald commented

Can you elaborate on what is difficult about using the FormatterRegistry API to register custom formatters and converters? It's a strongly typed interface, and doing the registration in Java instead of XML seems more elegant to me.

[spring-projects-issues]

Sebastian Beigel commented

With regard to setting up custom converters and/or formatters: Could you provide an example how to do this most elegantly? Right know (3.0 RC2) I have to declare a FormattingConversionServiceFactoryBean bean (and configure mvc:annotation-driven accordingly) and inject a parent DefaultConversionService in which I register the converters. Using no FormattingConversionServiceFactoryBean, I lose formatting for numbers and Joda Time... So what would be best practice to use custom converters and formatters?

[spring-projects-issues]

Keith Donald commented

I would recommend defining your own Factory bean like FormattingConverrsionServiceFactoryBean that registers exactly what you need. I do not recommend using a hierarchy.

[spring-projects-issues]

Sebastian Beigel commented

Looking at the current (trunk) version, this seems reasonable :) in RC2, it's quite painful (init* and install* methods are private for example in FormattingConversionServiceFactoryBean)... I will check this out w/ a nightly build.

Is there a release date for the next RC (or even the final release? It's really great that you are significantly improving things in the rc cycle, some people just fix bugs at this stage :) The Formatting/Conversion SPI looks much better in trunk than in RC2! Thanks for that!

[spring-projects-issues]

Sebastian Beigel commented

Oh, I think we can close this issue :)

[spring-projects-issues]

Sam Brannen commented

Superseded by #12388