Add full support for JPA 2.0 PersistenceUnitInfo [SPR-6408]

[spring-projects-issues]

Yanming Zhou opened SPR-6408 and commented

javax.persistence.spi.PersistenceUnitInfo add three methods in JPA2

@Override
public String getPersistenceXMLSchemaVersion() {
	return "1.0";
}

@Override
public SharedCacheMode getSharedCacheMode() {
	return SharedCacheMode.NONE;
}

@Override
public ValidationMode getValidationMode() {
	return ValidationMode.NONE;
}

please add it to org.springframework.orm.jpa.persistenceunit.MutablePersistenceUnitInfo

---

Issue Links:

• Spring 3.0 not compatible with Hibernate 3.5 beta3 [SPR-6705] #11371 Spring 3.0 not compatible with Hibernate 3.5 beta3

Referenced from: commits 0ba8375

2 votes, 6 watchers

[spring-projects-issues]

Juergen Hoeller commented

Spring 3.0 already comes with early JPA 2.0 support in the form of supporting the JPA 2.0 API for users: e.g. getQueryBuilder, unwrap, etc. This is done reflectively in order to be compatible with JPA 1.0 as well.

Unfortunately it is impossible to update our PersistenceUnitInfo at this point: The new methods in that interface refer tp SharedCacheMode and ValidationMode enums which are only present in the JPA 2.0 API. With those methods implemented, our MutablePersistenceUnitInfo class wouldn't load against the JPA 1.0 API anymore, so we'd suddenly require JPA 2.0. This is not justifiable at this point, and probably won't be justifiable for years to come since we need to remain compatible with Java EE 5 runtime environments where only JPA 1.0 is present - and where the JPA API can't be updated without a full server upgrade.

Juergen

[spring-projects-issues]

Julien HENRY commented

As a workaround, if your application is JPA 2 only, you can override org.springframework.orm.jpa.persistenceunit.MutablePersistenceUnitInfo by duplicating it in your application (putting it first in the classpath) and adding:

...
    @Override
    public String getPersistenceXMLSchemaVersion() {
        return "1.0";
    }

    @Override
    public SharedCacheMode getSharedCacheMode() {
        return SharedCacheMode.NONE;
    }

    @Override
    public ValidationMode getValidationMode() {
        return ValidationMode.NONE;
    }

[spring-projects-issues]

David J. M. Karlsen commented

Couldn't this be solved by providing two different jpa lib implementations? One for 1.0 and one for 2.0.
Or a factory selecting the compatible implementation based on introspection of the environment.
Now this is a blocker for JPA 2.0 usage - and 2.0 has quite some interesting stuff in it.

For instance with Hibernate 3.5:

Caused by: java.lang.AbstractMethodError: org.springframework.orm.jpa.persistenceunit.SpringPersistenceUnitInfo.getSharedCacheMode()Ljavax/persistence/SharedCacheMode;
at org.hibernate.ejb.util.LogHelper.logPersistenceUnitInfo(LogHelper.java:39) [hibernate-entitymanager-3.5.0-SNAPSHOT.jar:3.5.0-SNAPSHOT]
at org.hibernate.ejb.Ejb3Configuration.configure(Ejb3Configuration.java:407) [hibernate-entitymanager-3.5.0-SNAPSHOT.jar:3.5.0-SNAPSHOT]
at org.hibernate.ejb.HibernatePersistence.createContainerEntityManagerFactory(HibernatePersistence.java:165) [hibernate-entitymanager-3.5.0-SNAPSHOT.jar:3.5.0-SNAPSHOT]
at org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean.createNativeEntityManagerFactory(LocalContainerEntityManagerFactoryBean.java:225) [spring-orm-3.0.0.RELEASE.jar:3.0.0.RELEASE]
at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.afterPropertiesSet(AbstractEntityManagerFactoryBean.java:288) [spring-orm-3.0.0.RELEASE.jar:3.0.0.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1460) [spring-beans-3.0.0.RELEASE.jar:3.0.0.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1398) [spring-beans-3.0.0.RELEASE.jar:3.0.0.RELEASE]
... 51 common frames omitted

[spring-projects-issues]

Juergen Hoeller commented

Hmm, EclipseLink 2.0 doesn't seem to actually call those new PersistenceUnitInfo methods, or only calls them within a catch block in order to be compatible with JPA 1.0 PUIs... whereas Hibernate 3.5 seems to actually call them, even in its logging code.

Anyway, there are solutions to make this work in Spring 3.0.x already, such as using dynamic PersistenceUnitInfo proxies that reflectively implement JPA 2.0 methods as well. We'll provide this in Spring 3.0.1 unless there is a showstopper.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

Actually, this problem only seems to occur with Hibernate 3.5 beta 3 snapshots. The public beta 2 release works fine with Spring 3.0 GA, as does EclipseLink 2.0.0.

In any case, I've added PersistenceUnitInfo adapting through a proxy when the JPA 2.0 API is present. We're also parsing shared-cache-mode and validation-mode entries in persistence.xml now. This will be available in tonight's snapshot already; feel free to give it a try!

Juergen

[spring-projects-issues]

David J. M. Karlsen commented

Yes, this is only with the SNAPSHOT/upcomong beta-3 of hibernate.
I'm actually running on snapshots of cxf, spring batch and hibernate to check out for integration style problems.

Now as the s3browse service is gone - how can I browse the repo?
What is the name of the latest spring 3.0.1 snapshot?

[spring-projects-issues]

Juergen Hoeller commented

It's going to be snapshot 538, available from http://static.springsource.org/downloads/nightly/snapshot-download.php?project=SPR tonight.

You can browse the Spring 3.0 repo at https://src.springframework.org/svn/spring-framework/ - it contains this latest JPA fix already.

Juergen

[spring-projects-issues]

David J. M. Karlsen commented

No maven repo - like for Spring Batch? I think that would increase the chances of the audience testing snapshots as they are pushed out.

[spring-projects-issues]

Juergen Hoeller commented

There is a Maven repo at http://maven.springframework.org/snapshot, using version "3.0.1.SNAPSHOT".

See Keith's article: http://blog.springsource.com/2009/12/02/obtaining-spring-3-artifacts-with-maven/

Juergen

[spring-projects-issues]

David J. M. Karlsen commented

Doesn't seem to be there: http://s3.amazonaws.com/maven.springframework.org/snapshot/org/springframework/spring-core/3.0.1.SNAPSHOT/spring-core-3.0.1.SNAPSHOT.jar ?
It would be a lot easier if I didn't have to open an s3 account and pay to browse the repo.

[spring-projects-issues]

Oliver Drotbohm commented

Hey David,

there seems to be a subtle issue in Keith's blog post. The version numbers for snapshots are 3.0.1.BUILD-SNAPSHOT. I've tried to get the artifacts from the EBR and it worked, maybe you simply try from the standard Maven style ones, too.

Regards,
Ollie

[spring-projects-issues]

David J. M. Karlsen commented

Yes, I noticed as well as I stumbled over somebody else using this version, my point being that if we could browse the repo we could be self-served about this.

[spring-projects-issues]

Keith Donald commented

Go ahead and add a JIRA requesting a browseable interface to our s3 milestone and snapshot repositories. It'd be good to have it in a JIRA where the community can vote on it and the development team can track it.

I've asked Ben Hale to explain why we chose BUILD-SNAPSHOT as the snapshot label when the rest of the world seems to use SNAPSHOT.

[spring-projects-issues]

Keith Donald commented

The reason the snapshot label is x.y.z.BUILD-SNAPSHOT instead of the Maven 2 standard x.y.z-SNAPSHOT, is because x.y.z-SNAPSHOT is not a valid OSGi version number, and all Spring releases since 3.0.0.M1 use OSGi version naming format (which Maven 3 is also adopting). x.y.z.BUILD-SNAPSHOT is a good "new standard" that is OSGi compliant and recognized by existing versions of Maven. I'm going to update my blog with a note on this.

[spring-projects-issues]

Phill Moran commented

Is this really fixed I get the same error for OpenJPA mentioned above for JDK1.6?