parseStringValue gone from PropertyPlaceholderConfigurer [SPR-6159]

[spring-projects-issues]

Kenny MacLeod opened SPR-6159 and commented

Between 3.0.0 M4 and RC1, the protected parseStrongValue method disappeared from PropertyPlaceholderConfigurer. For custom subclasses, this method was the main entry point into the superclass functionality. Since it had not been deprecated, it seemed like the correct thing to do, but has now been removed, breaking compile-time compatibility between 2.5 and 3.0.

Can the method be reinstated somehow, that perhaps invokes the new methods that do the work? It can then be marked as deprecated.

---

Affects: 3.0 RC1

Issue Links:

• parseStringValue gone from PropertyPlaceholderConfigurer [SPR-6315] #10981 parseStringValue gone from PropertyPlaceholderConfigurer ("is duplicated by")

2 votes, 2 watchers

[spring-projects-issues]

Kenny MacLeod commented

After looking through the source for the RC1 version of PropertyPlaceholderConfigurer, it seems that the mechanism for the recursive parsing of placeholders that was in the M4 has been completely rewritten and replaced by a new mechanism that uses a BeanFactory visitor. This substantially reduces the reusability of PropertyPlaceholderConfigurer, typing the property parsing to the BeanFactory. Pre-RC1, it was a more generic mechanism, or least, that's the way I'm reading it.

My use case here is resolving placeholders from a property set that's contained within a legacy application object. I was using parseStringValue() from PropertyPlaceholderConfigurer to recursively resolve the placeholder.

[spring-projects-issues]

Rob Rudin commented

I've got the same issue. I had to copy/paste the two private classes - PlaceholderResolvingStringValueResolver and PropertyPlaceholderConfigurerResolver - into my extension of PropertyPlaceholderConfigurer in order to get my extension working again.

Seems like a protected method in PropertyPlaceholderConfigurer could still provide access to the StringValueResolver mechanism that is used for recursive resolving.

[spring-projects-issues]

Kenny MacLeod commented

Can we have some indication of a fix-for on this, please?

[spring-projects-issues]

Kenny MacLeod commented

I've refiled this as a bug under #10981, since I suspect having this issue marked as "refactor" means it might get ignored until it's too late.