Support Tiles 2.2 for Velocity and FreeMarker purposes [SPR-5609]

[spring-projects-issues]

Canny Duck opened SPR-5609 and commented

---

Affects: 3.0 M2, 3.0 GA

Issue Links:

• TilesConfigurer class no longer works with Tiles 2.1.1 [SPR-5411] #10084 TilesConfigurer class no longer works with Tiles 2.1.1
• TilesConfigurer does not support the new configuration model of Tiles 2.2 [SPR-6097] #10765 TilesConfigurer does not support the new configuration model of Tiles 2.2

4 votes, 7 watchers

[spring-projects-issues]

Juergen Hoeller commented

We already have #10084 for Tiles 2.1 support. What exactly would you expect to see in terms of Tiles-Velocity integration?

[spring-projects-issues]

Matt Benson commented

velocity and freemarker Tiles subcomponents have been created and are slated for release with Tiles v2.2.0. You might modify #10084 to target Tiles v2.2.0 and close this one out.

[spring-projects-issues]

Juergen Hoeller commented

I'm afraid we'll have to stick with Tiles 2.1.x for Spring 3.0, since I don't see Tiles 2.2 being released in time for our RC1 in June...

Juergen

[spring-projects-issues]

Matt Benson commented

Actually, as I understand it, configuration is what's broken in Spring wrt Tiles 2.1.x, and I don't see anything in their JIRA that indicates configuration incompatibilities from v2.1.x to 2.2.x, so Spring should get 2.2.x support for free by supporting 2.1.x.

[spring-projects-issues]

Rick Mangi commented

Tiles 2.2 changed the way initialization is done. It does not seem to work in spring 3.0.0.M4. It seems like it should be easy to configure however by creating a subclass of AbstractTilesInitializer and exposing it to the dispatcher-servlet context. Tiles 2.2 supports a lot of new features and it would be great to make it a first class citizen of spring 3.

[spring-projects-issues]

Marino A. Jonsson commented

Just set up a little test project using Spring v2.5.6.SEC0, Tiles v2.2.0 and Velocity v1.6.2 with Velocity-Tools v2.0-beta4 and got everything working, using essentially the same configuration classes Bjorn Harvold posted in #10084 (custom configurer, initializer and containerFactory).

Here is how I gave Velocity access to the Spring macros (along with the springMacroRequestContext):

• First, TilesView needs to extend AbstractTemplateView instead of AbstractUrlBasedView and the contents of TilesView.renderMergedOutputModel() need to be moved to renderMergedTemplateModel()
• Velocity can then be configured using velocity.properties or using a few VelocityAttributeRenderer.setParameter(String, String) calls in the TilesContainer:

resource.loader=webapp,springMacro
springMacro.resource.loader.class=org.apache.velocity.runtime.resource.loader.ClasspathResourceLoader
velocimacro.library = /WEB-INF/VM_global_library.vm,org/springframework/web/servlet/view/velocity/spring.vm

Also, I agree with Matt, the new way of configuring Tiles seems to have been introduced in v2.1 and it seems unchanged in v2.2.

[spring-projects-issues]

mck commented

A patch has been submitted for #10765 which should in turn fix this issue.

[spring-projects-issues]

Juergen Hoeller commented

This should have been dealt with in Spring 3.0.1 now. Let me know if anything doesn't work for you still; we can roll this into 3.0.2 then.

Juergen