org.springframework.web.servlet.tags.form.TagIdGenerator doesn't remove characters [] and double-quotes [SPR-5382]

[spring-projects-issues]

Ilya opened SPR-5382 and commented

org.springframework.web.servlet.tags.form.TagIdGenerator which is used by tags checkboxes and radiobuttons doesn't filter out [] and double-quotes from id attribute. It breaks html and javascript for map-based properties. Can be fixed like this:

public static String nextId(String name, PageContext pageContext) {
	String attributeName = PAGE_CONTEXT_ATTRIBUTE_PREFIX + name;
	Integer currentCount = (Integer) pageContext.getAttribute(attributeName);
	currentCount = (currentCount != null ? new Integer(currentCount.intValue() + 1) : new Integer(1));
	pageContext.setAttribute(attributeName, currentCount);
	return (StringUtils.deleteAny(name, "[]\"") + currentCount.intValue());
}

---

Issue Links:

• Spring MVC regression: binding to indexed properties is broken [SPR-6871] #11537 Spring MVC regression: binding to indexed properties is broken
• form:checkbox tag creates invalid HTML id when bound to indexed property [SPR-6840] #11506 form:checkbox tag creates invalid HTML id when bound to indexed property

Backported to: 3.0.1

[spring-projects-issues]

Juergen Hoeller commented

This should be fixed since Spring 3.0.1/3.0.2 now, through a change in AbstractDataBoundFormElementTag which removes invalid characters before even passing the name to TagIdGenerator.

Juergen