DATAJDBC-100 Namespaces / @EnableJdbcRepositories #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the @EnableJdbcRepositories annotation, which when used on a Spring configuration enables scanning packages for JDBC-repositories.
odrotbohm
requested changes
Jun 20, 2017
|
|
||
| private NamedParameterJdbcOperations findOrCreateJdbcOperations() { | ||
|
|
||
| return getNamedParameterJdbcOperations() // |
Member
There was a problem hiding this comment.
Remove nesting by using Optionals.firstNonEmpty(…)-
| } | ||
|
|
||
| private Optional<NamedParameterJdbcOperations> getNamedParameterJdbcOperations() { | ||
| return getBean(NamedParameterJdbcOperations.class, "namedParameterJdbcOperations"); |
Member
There was a problem hiding this comment.
Names as constants. Align with Boot defaults, i.e. Operations -> Template. Types should stay with Operations.
| /* | ||
| * (non-Javadoc | ||
| * @see * @see org.springframework.data.repository.config | ||
| .RepositoryConfigurationExtensionSupport#getRepositoryFactoryBeanClassName() |
Changed bean names to those used by Boot. Extracted constants for bean names (in the production classes and test classes separately). Renamed an existing constant to avoid confusion. Fixed some garbled non-javadoc comments.
odrotbohm
pushed a commit
that referenced
this pull request
Jun 20, 2017
Adds the @EnableJdbcRepositories annotation, which when used on a Spring configuration enables scanning packages for JDBC repositories. Original pull request: #6.
Member
|
That's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the @EnableJdbcRepositories annotation, which when used on a Spring configuration enables scanning packages for JDBC-repositories.
Issue: https://jira.spring.io/browse/DATAJDBC-100