Skip to content

DATAJDBC-444 Add getColumnAlias for RelationalPersistentProperty #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhyeon-lee wants to merge 2 commits into from
Closed

DATAJDBC-444 Add getColumnAlias for RelationalPersistentProperty #179

mhyeon-lee wants to merge 2 commits into from

Conversation

@mhyeon-lee
Copy link
Contributor

@mhyeon-lee mhyeon-lee commented Nov 14, 2019

  • Add getColumnAlias ​​method to RelationalPersistentProperty, and use it in PersistentPropertyPathExtension.
  • getColumnAlias ​​delegates getColumnName as the default method to maintain the same behavior as before.

DATAJDBC-444

@mhyeon-lee
Copy link
Contributor Author

mhyeon-lee commented Jan 5, 2020

No opinions about this PR?
My team is extending Spring Data JDBC to apply to Internal Sharding Solution.
This solution requires this PR to be extended to manage the sharding key.

@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2021
@gregturn gregturn changed the base branch from master to main April 15, 2021 18:21
@schauder
Copy link
Contributor

schauder commented Oct 20, 2021

Thanks for your work, but as mentioned in #664 this doesn't work since the alias depends on the full path, not just a single property.

@schauder schauder closed this Oct 20, 2021
@schauder schauder added the status: declined A suggestion or change that we don't feel we should currently apply label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: declined A suggestion or change that we don't feel we should currently apply status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhyeon-lee @schauder @spring-projects-issues