Fix broken join conditions with InlineQuery. #1368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Adds a test demonstrating that the join condition of inline queries messes up those of outer joins. Original pull request #1362
schauder
force-pushed
the
issue/1362-inline-query
branch
2 times, most recently
from
f9a5853 to
670ae6f
Compare
Before this fix, whenever a column of an inline query was rendered the `InlineQuery` and all its children were visited, resulting in spurious output. This is no prevented by injecting a NoopVisitor. Closes #1362
schauder
force-pushed
the
issue/1362-inline-query
branch
from
670ae6f to
d9a2829
Compare
Member
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, whenever a column of an inline query was rendered the
InlineQueryand all its children were visited, resulting in spurious output.This is no prevented by injecting a NoopVisitor.
Supersedes #1362