findById never returns Empty, but throws an exception instead. [DATAJDBC-124]

[spring-projects-issues]

Jens Schauder opened DATAJDBC-124 and commented

I did not completely verify this but I'm under the impression that findById doesn't return Optional.empty but instead throws an exeception instead

---

Referenced from: pull request #14, and commits ff50ae4, 1d63be8, 2067fb6

[spring-projects-issues]

Jens Schauder commented

The root problem is that the NamedParameterJdbcTemplate throws an exception on zero results in queryForObject.

I saw two options to fix this:

a) use query instead of queryForObject and basically reimplementing the check for 0/1/N results, already present in NamedParameterJdbcTemplate

b) catch the right exception and convert it to an Optional.empty

I went with the second approach because:

1. It makes our template behave similar to that of the spring framework
2. It avoids reimplementing the cardinality check which feels just as ugly as using exceptions for flow control.

[spring-projects-issues]

Greg Turnquist commented

I agree with your decision, unless something like performance bubbled up as grossly different in this solution