#189 - Accept StatementFilterFunction in DatabaseClient #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
force-pushed
the
issue/gh-189
branch
from
876a49e to
309ccd5
Compare
schauder
reviewed
Feb 25, 2020
Contributor
schauder
left a comment
schauder
left a comment
There was a problem hiding this comment.
Two minor issues and once more I'm not happy with a name without a real good alternative.
I also rebased and prepared two polishing commits.
| Spring Data R2DBC lets you use native bind markers or named bind markers with the `:name` syntax. | ||
| Named parameter support leverages a `R2dbcDialect` instance to expand named parameters to native bind markers at the time of query execution, which gives you a certain degree of query portability across various database vendors. | ||
| Named parameter support leverages a `R2dbcDialect` instance to expand named parameters to native bind markers at the time of query execution, which gives you a certain degree of query portability across various database vendors. |
Contributor
There was a problem hiding this comment.
I'm not sure I like the name filter. I would expect it to accept a Predicate.
I don't have a name I really like but maybe somthing like registerStatementCallback, or modifyStatement?
Or to go with the more functional nomenclature it would be a map, maybe a mapStatement?
| Map<String, SettableValue> byName, Supplier<String> sqlSupplier) { | ||
| return createTypedExecuteSpec(byIndex, byName, sqlSupplier, this.typeToRead); | ||
| Map<String, SettableValue> byName, Supplier<String> sqlSupplier, StatementFilterFunction filterFunction) { | ||
| return createTypedExecuteSpec(byIndex, byName, sqlSupplier, filterFunction, this.typeToRead); |
Contributor
There was a problem hiding this comment.
typeToRead is nullable but gets passed as an argument to a parameter which is not nullable and eventually actually gets dereferenced.
I'm not sure if there is something really wrong or if the nullability annotations need tweaking.
| this.filterFunction = filterFunction; | ||
| } | ||
|
|
||
| <T> FetchSpec<T> exchange(Supplier<String> sqlSupplier, BiFunction<Row, RowMetadata, T> mappingFunction) { |
Contributor
There was a problem hiding this comment.
This is actually about the line Function<Connection, Statement> executeFunction = it -> { a few lines down.
It now clashes awkwardly with ExecuteFunction and the member of that type also named executeFunction. I think something should get a name change here.
We now accept StatementFilterFunction and ExecuteFunction via DatabaseClient to filter Statement execution. StatementFilterFunctions can be used to pre-process the statement or post-process Result objects.
databaseClient.execute(…)
.filter((s, next) -> next.execute(s.returnGeneratedValues("my_id")))
.filter((s, next) -> next.execute(s.fetchSize(25)))
databaseClient.execute(…)
.filter(s -> s.returnGeneratedValues("my_id"))
.filter(s -> s.fetchSize(25))
Made assertions in tests more strict.
Refactored DefaultDatabaseClientUnitTests in order to make the relevant differences in setup easier to spot.
Fix nullability annotations. Relax generics at DatabaseClient.StatementFilterSpec.filter(…).
schauder
pushed a commit
that referenced
this pull request
Mar 17, 2020
We now accept StatementFilterFunction and ExecuteFunction via DatabaseClient to filter Statement execution. StatementFilterFunctions can be used to pre-process the statement or post-process Result objects.
databaseClient.execute(…)
.filter((s, next) -> next.execute(s.returnGeneratedValues("my_id")))
.filter((s, next) -> next.execute(s.fetchSize(25)))
databaseClient.execute(…)
.filter(s -> s.returnGeneratedValues("my_id"))
.filter(s -> s.fetchSize(25))
Original pull request: #308.
schauder
added a commit
that referenced
this pull request
Mar 17, 2020
Made assertions in tests more strict. Original pull request: #308.
schauder
added a commit
that referenced
this pull request
Mar 17, 2020
Refactored DefaultDatabaseClientUnitTests in order to make the relevant differences in setup easier to spot. Original pull request: #308.
schauder
pushed a commit
that referenced
this pull request
Mar 17, 2020
Fix nullability annotations. Relax generics at DatabaseClient.StatementFilterSpec.filter(…). Original pull request: #308.
schauder
added a commit
that referenced
this pull request
Mar 17, 2020
Minor formatting. Original pull request: #308.
Contributor
|
That's merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now accept
StatementFilterFunctionandExecuteFunctionviaDatabaseClientto filter Statement execution. StatementFilterFunctions can be used to pre-process the statement or post-process Result objects.Related ticket: #189.