Skip to content

Replace regex with startsWith / endsWith check for LIKE pattern detection #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replace regex with startsWith / endsWith check for LIKE pattern detection #3932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...ata-jpa/src/main/java/org/springframework/data/jpa/repository/query/ParameterBinding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,8 @@ static class LikeParameterBinding extends ParameterBinding {
private static final List<Type> SUPPORTED_TYPES = Arrays.asList(Type.CONTAINING, Type.STARTING_WITH,
Type.ENDING_WITH, Type.LIKE);

private static final String PERCENT = "%";

private final Type type;

/**
Expand Down Expand Up @@ -464,15 +466,15 @@ static Type getLikeTypeFrom(String expression) {

Assert.hasText(expression, "Expression must not be null or empty");

if (expression.matches("%.*%")) {
if (expression.startsWith(PERCENT) && expression.endsWith(PERCENT)) {
return Type.CONTAINING;
}

if (expression.startsWith("%")) {
if (expression.startsWith(PERCENT)) {
return Type.ENDING_WITH;
}

if (expression.endsWith("%")) {
if (expression.endsWith(PERCENT)) {
return Type.STARTING_WITH;
}

Expand Down