Rewrite String queries for DTO Constructor Expressions #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is DTO. We now rewrite String-based JPA queries to use constructor expressions when either selecting the entity or selecting individual properties. We do not rewrite queries that already use constructor expressions.
Also, interface-based projections now use Tuple queries to consistently use tuple-based queries.
Refactor code duplications.
Seol-JY
reviewed
Nov 7, 2024
Comment on lines
+77
to
+79
| } else if (obj instanceof FactoryExpression) { | ||
| FactoryExpression<?> c = (FactoryExpression<?>) obj; | ||
| return args.equals(c.getArgs()) && getType().equals(c.getType()); |
There was a problem hiding this comment.
Suggested change
| } else if (obj instanceof FactoryExpression) { | |
| FactoryExpression<?> c = (FactoryExpression<?>) obj; | |
| return args.equals(c.getArgs()) && getType().equals(c.getType()); | |
| } else if (obj instanceof FactoryExpression<?> c) { | |
| return args.equals(c.getArgs()) && getType().equals(c.getType()); |
I recommend changing the instanceof check to use pattern matching feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3076
Closes #2327