Skip to content

Conversation

@meistermeier
Copy link
Contributor

@meistermeier meistermeier commented Jul 26, 2021

As a result there will be a Map<PropertyPath, Boolean>, indicating if the property path "ends" in an entity or not, that can get used as input for a selection/mapping filter in the dedicated store modules.
Maybe it might makes sense to wrap the Map<PropertyPath, Boolean> into an own class. For us it is sufficient right now to use the map.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 26, 2021
@meistermeier meistermeier marked this pull request as draft September 20, 2021 06:19
@meistermeier meistermeier force-pushed the issue/multilevel-projections branch from cf8807d to 08ac9d0 Compare September 20, 2021 08:46
@meistermeier meistermeier marked this pull request as ready for review September 20, 2021 08:47
@schauder
Copy link
Contributor

schauder commented Oct 26, 2021

Isn't a Map<X,Boolean> simply a Set<X>? Or do we need the ternary logic of "it neither bescause it isn't in the Map"?

@meistermeier
Copy link
Contributor Author

This is the problem with partially extracted and outdated documented things (This class is responsible for creating a List of..). In the end we (SDN) need the information if the PropertyPath points towards an entity or not (simple type, other projection definition).

@mp911de mp911de self-assigned this Nov 15, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 1, 2021
christophstrobl pushed a commit that referenced this pull request Dec 13, 2021
christophstrobl pushed a commit that referenced this pull request Dec 13, 2021
christophstrobl pushed a commit that referenced this pull request Dec 13, 2021
Original Pull Request: #2420
christophstrobl pushed a commit that referenced this pull request Dec 13, 2021
Original Pull Request: #2420
christophstrobl pushed a commit that referenced this pull request Dec 13, 2021
christophstrobl pushed a commit that referenced this pull request Dec 13, 2021
christophstrobl added a commit that referenced this pull request Dec 13, 2021
Replace boolean flag with enum, assert open vs. closed projection and update javadoc.

Original Pull Request: #2420
@christophstrobl
Copy link
Member

Thanks @meistermeier! Now available on main now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants