Skip to content

Conversation

@tan9
Copy link
Contributor

@tan9 tan9 commented Nov 30, 2016

If the pathname of fully executable contains any space characters, the launch script will failed to locate the jar file like:
Error: Unable to access jarfile /Users/tang/My

This patch fix this issue by quoting the jarfile when invoking java process.

If the pathname of fully executable contains any space characters, the launch script will failed to locate the jar file like:
`Error: Unable to access jarfile /Users/tang/My `

This patch fix this issue by quoting the jarfile when invoking java process.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2016
@tan9
Copy link
Contributor Author

tan9 commented Nov 30, 2016

I have no idea why EndpointWebMvcAutoConfigurationTests.disable test case failed in Travis CI.

@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 30, 2016
@philwebb philwebb added this to the 1.4.3 milestone Nov 30, 2016
@philwebb
Copy link
Member

Could the Bash masters @wilkinsona or @dsyer just confirm this one?

@wilkinsona
Copy link
Member

I looked earlier and thought it looked fine. shellcheck seemed to agree.

@dsyer
Copy link
Member

dsyer commented Nov 30, 2016

LGTM

wilkinsona added a commit that referenced this pull request Dec 2, 2016
* gh-7535:
  Quote $jarfile when creating arguments in launch script
@wilkinsona wilkinsona closed this in 5a5e2db Dec 2, 2016
@wilkinsona
Copy link
Member

Thanks for the PR, @tan9!

@tan9 tan9 deleted the patch-3 branch December 4, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants