server.connection-timeout configures main Tomcat connector instead #7425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
philwebb
added a commit
that referenced
this pull request
Nov 22, 2016
Update the Tomcat sample to also test that the connection timeout is set. See gh-7425
philwebb
added a commit
that referenced
this pull request
Nov 22, 2016
* pr/7425: Add additional Tomcat timeout test Fix connector used to configure connection timeout
|
Is this bug fixed? |
|
@TejasRawat We believe so. The status of the issue is closed and the milestone is set to 1.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I discovered that
server.connection-timeouthas no effect for Tomcat's main connector and default value of 60000 is always used.I observed this behavior with Spring Boot 1.4.
As far as I can see this happens because
org.springframework.boot.autoconfigure.web.ServerProperties.customizeConnectionTimeoutmodifies only additional Tomcat connectors and keeping main one untouched.There is also Demo project to illustrate this problem.
PS
I hope this pull request would be helpful.
And thanks for great framework :)