using getSingleton method in ResetMocksListener resolves gh-7270 #7271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
status: on-hold
|
Thanks for the PR, @alebar. I'm labelling this as on hold until we figure out the best way to fix this. Please see my comments on #7270 for some more details. |
wilkinsona
added a commit
that referenced
this pull request
Nov 25, 2016
* gh-7271: Test that a broken factory bean does not break resetting of mocks Prevent a broken factory bean from breaking the resetting of mocks
wilkinsona
added a commit
that referenced
this pull request
Feb 1, 2023
An unwanted side-effect of the changes made in c6bdd13 to fix gh-7271 is that a mock produced by a factory bean is not reset. To allow such a mock to be reset without regressing the fix we now call getBean(…) as we did before c6bdd13, however the call is now performed in a defensive manner falling back to getSingleton(…) when it fails. Closes gh-33830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frankly: I'm not sure what exactly is happening here, but I guess that if we're depending on singletons registered in the factory then we should stick to singletons - not beans.
This PR resolves this issue: #7270
I hope this helps,
Alek