Neo4j bolt #6746
Neo4j bolt #6746
Conversation
gh-6690 Signed-off-by: Caleb Cushing <[email protected]>
gh-6690 Signed-off-by: Caleb Cushing <[email protected]>
gh-6690 Signed-off-by: Caleb Cushing <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: enhancement
|
should probably also take this opportunity to add support for https as well? |
|
@vince-bickers not in this issue, no. Feel free to create a separate PR for that. |
|
let me know if I need to make any changes to the code/commits before they can be merged. |
| driverConfiguration.setDriverClassName(BOLT_DRIVER); | ||
| driverConfiguration.setURI( DEFAULT_BOLT_URI ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
That's a breaking in behaviour. If you didn't specify anything and you upgrade, you're using bolt instead of http. I need to better understand the impact of this change before considering the code as is.
There was a problem hiding this comment.
my assumption on this is simply that since spring boot/platform doesn't provide this driver (or the file one) that if you add it manually, you probably want to use it, I'm ok if this isn't auto behavior, that just made sense to me.
|
I remember why I didn't support @xenoterracide I am a bit confused. I see no indication in your PR that Spring Boot provides dependency management for the bolt driver. We don't have dependency management for |
snicoll
added
status: waiting-for-feedback
snicoll
removed
status: on-hold
* pr/6746: Polish contribution Detect Neo4j bolt driver
|
I changed my mind. The bolt URL parsing has been merged in master. Regarding the detection of the bolt driver and the behaviour change, we can't do that in a bug fix release. Feel free to submit another issue for 1.5 but if you do, I'd like to get more details (per my previous comment). Thanks for the PR. |
4 participants
add autoconfiguration for bolt driver, including tests
gh-6690