Fix health endpoint visibility #6540
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays, health endpoint is partially visible to every role but completely visible to users with ROLE_ADMIN. This is due to HealthMvcEndpoint is looking at key `management.security.role` instead of `management.security.roles`.
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Oops :) |
philwebb
added
type: blocker
snicoll
pushed a commit
that referenced
this pull request
Aug 13, 2016
Commit b02aba4 has renamed `management.security.role` to `management.security.roles`. Unfortunately, the `HealthMvcEndpoint` was still looking at the old property. This commit makes sure that the proper key is used and any custom role is applied rather than an unconditional `ADMIN` role. See gh-6540
snicoll
added a commit
that referenced
this pull request
Aug 13, 2016
* pr/6540: Polish contribution Fix health endpoint security
Member
|
Thanks for the PR @eddumelendez - I've polished it in 4882544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, health endpoint is partially visible to every role but completely visible
to users with ROLE_ADMIN. This is due to HealthMvcEndpoint is looking at key
management.security.roleinstead ofmanagement.security.roles.