CodahaleMetricWriter fails under load test due to parallel access to writer and gauges #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. Did you (and can you if not) fill in the contributor's agreement (link in README)? |
gigfork
pushed a commit
to boostrack/spring-boot
that referenced
this pull request
Apr 21, 2014
mdeinum
pushed a commit
to mdeinum/spring-boot
that referenced
this pull request
Jun 6, 2014
Liwenbai
pushed a commit
to Liwenbai/spring-boot
that referenced
this pull request
Jun 10, 2025
com.sun.jndi.ldap.LdapCtxFactory is not supposed to be used by anyone but the 'java.naming' module in post Java 8 world. Fixes spring-projects#543
Liwenbai
pushed a commit
to Liwenbai/spring-boot
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MetricFilter that delegates to the CodahaleMetricWriter fails when taking several parallel requests to the same URL as it tries to update a gauge which causes a
registry.removefollowed byregistry.register. The latter fails if two threads callregisterback to back as the first will register and the second will fail as having already been registered.This pull request adds a test case showcasing the error and offers a fix by synchronizing on the registry. Synchronizing is not the best choice due to blocking in the parallism, but I do not see a better way to avoid the error scenario with the API that Codahale exposes.